-
Notifications
You must be signed in to change notification settings - Fork 13.3k
incr.comp.: Let the compiler ignore incompatible incr. comp. cache artifacts #36758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incr.comp.: Let the compiler ignore incompatible incr. comp. cache artifacts #36758
Conversation
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ |
📌 Commit 1e5c253 has been approved by |
I'm seeing travis fail with this:
|
Blargh, I should've seen that coming. @bors r- |
/// A version string that hopefully is always different for compiler versions | ||
/// with different encodings of incremental compilation artifacts. Contains | ||
/// the git commit hash. | ||
const RUSTC_VERSION: &'static str = env!("CFG_VERSION"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought you had a reason for not following suit, but it appears rustc_incremental
is also tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, I ran across this and then forgot about again. Should be fixed now (but let's wait for travis).
@bors r+ |
📌 Commit 263ba92 has been approved by |
incr.comp.: Let the compiler ignore incompatible incr. comp. cache artifacts Implements #35720. cc @nikomatsakis
Implements #35720.
cc @nikomatsakis