Skip to content

do not use deprecated text for unstable docs #37758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2016
Merged

Conversation

euclio
Copy link
Contributor

@euclio euclio commented Nov 13, 2016

Before

2016-11-13-18 55 23
2016-11-13-18 55 12

After

2016-11-13-18 54 00
2016-11-13-18 54 45

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@@ -2890,7 +2890,8 @@ pub struct Stability {
pub feature: String,
pub since: String,
pub deprecated_since: String,
pub reason: String,
pub deprecated_reason: String,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason (no pun intended) these shouldn't be Options?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like they should be, but that can be done in a follow up.

@brson
Copy link
Contributor

brson commented Nov 15, 2016

@bors r+

Nice fix.

@bors
Copy link
Collaborator

bors commented Nov 15, 2016

📌 Commit 30f75e3 has been approved by brson

@bors
Copy link
Collaborator

bors commented Nov 15, 2016

⌛ Testing commit 30f75e3 with merge 1e5b4c0...

@alexcrichton
Copy link
Member

@bors: retry force clean

  • restarted buildbot

@bors
Copy link
Collaborator

bors commented Nov 15, 2016

⌛ Testing commit 30f75e3 with merge c87bae6...

@bors bors merged commit 30f75e3 into rust-lang:master Nov 16, 2016
@euclio euclio deleted the unstable branch February 7, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants