-
Notifications
You must be signed in to change notification settings - Fork 13.4k
do not use deprecated text for unstable docs #37758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@@ -2890,7 +2890,8 @@ pub struct Stability { | |||
pub feature: String, | |||
pub since: String, | |||
pub deprecated_since: String, | |||
pub reason: String, | |||
pub deprecated_reason: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason (no pun intended) these shouldn't be Option
s?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like they should be, but that can be done in a follow up.
@bors r+ Nice fix. |
📌 Commit 30f75e3 has been approved by |
⌛ Testing commit 30f75e3 with merge 1e5b4c0... |
@bors: retry force clean
|
do not use deprecated text for unstable docs    
Before
After