Add missing urls and improve internal doc representation #37804
Conversation
| @@ -231,6 +234,8 @@ impl Ipv4Addr { | |||
| /// - the broadcast address (255.255.255.255/32) | |||
| /// - test addresses used for documentation (192.0.2.0/24, 198.51.100.0/24 and 203.0.113.0/24) | |||
| /// - the unspecified address (0.0.0.0) | |||
| /// | |||
| /// [ipv4-sr]: http://goo.gl/RaZ7lg | |||
There was a problem hiding this comment.
Any idea why this is a shortened url? Do we have a way to break up long URLs?
There was a problem hiding this comment.
By clicking on it? :p
There was a problem hiding this comment.
To rephrase my previous question: Why don't we just put the target URL here instead of the shortened URL? Not a big deal though, just curious
There was a problem hiding this comment.
I believe it's to please make tidy's line length check. We should find a better way though. If we add ignore-tidy-linelength to the file then we can use the full URL but then the whole file won't be checked.
| /// [ip7][http://man7.org/linux/man-pages/man7/ip.7.html] | ||
| /// W. Richard Stevens, p. 891; see also [ip7]. | ||
| /// | ||
| /// [ip7]: (http://man7.org/linux/man-pages/man7/ip.7.html) |
There was a problem hiding this comment.
std/net/struct.Ipv4Addr.html:63: broken link - std/net/(http:/man7.org/linux/man-pages/man7/ip.7.html)
GuillaumeGomez
force-pushed
the
net_urls
branch
from
27acb5c to
21f577f
Compare
|
@bors r+ rollup |
|
Just kidding, wasn't delegated for this one. r=me anyways. |
|
@frewsxcv give me one second 😉 |
|
@bors r+ rollup |
|
@bors: delegate=frewsxcv |
|
Damn... Let's do it the old way. @bors: r=frewsxcv rollup |
|
@bors r- |
|
@bors r+ rollup |
|
@bors r- (Sorry for the spam) |
|
@bors r+ rollup |
|
@bors: r=frewsxcv |
|
📌 Commit 21f577f has been approved by |
|
Finally! \o/ |
|
@bors p=-1000 |
|
@bors rollup- |
|
Woooo, it's working! @bors rollup |
|
☔ The latest upstream changes (presumably #37837) made this pull request unmergeable. Please resolve the merge conflicts. |
GuillaumeGomez
force-pushed
the
net_urls
branch
from
21f577f to
509d14f
Compare
r? @steveklabnik