Add tests for incremental reuse scenarios #37842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| /// A fn item that calls (public) methods on `Point` from the same impl which changed |
There was a problem hiding this comment.
This comment seems wrong.
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
|
|
||
| // Test where we change the body of a private method in an impl. |
There was a problem hiding this comment.
But the changed method is public?
| // except according to those terms. | ||
|
|
||
| // Test where we change the body of a private method in an impl. | ||
| // We then test what sort of functions must be rebuilt as a result. |
|
@michaelwoerister oh yeah shoot I forgot to go fixup the comments |
Ideally, callers should not be affected, but they currently are.
nikomatsakis
force-pushed
the
incremental-test
branch
from
f36e448 to
36f2af1
Compare
|
@bors r=mw |
|
📌 Commit 36f2af1 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 20, 2016
Add tests for incremental reuse scenarios These are microbenchmarks checking that we achieve the expected reuse in the scenarios covered by incremental beta. r? @michaelwoerister
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are microbenchmarks checking that we achieve the expected reuse in the scenarios covered by incremental beta.
r? @michaelwoerister