Skip to content

macros: improve resolution performance #37951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2016

Conversation

jseyfried
Copy link
Contributor

Avoid quadratic legacy macro name resolution in more cases.
r? @nrc

@jseyfried
Copy link
Contributor Author

jseyfried commented Nov 23, 2016

This improves expansion performance for @michaelwoerister's example by a factor of 8.

@nrc
Copy link
Member

nrc commented Nov 23, 2016

@bors: r+

@bors
Copy link
Collaborator

bors commented Nov 23, 2016

📌 Commit cbe4787 has been approved by nrc

@michaelwoerister
Copy link
Member

@jseyfried Cool, faster than before :)

@bors
Copy link
Collaborator

bors commented Nov 24, 2016

⌛ Testing commit cbe4787 with merge d9bdc63...

bors added a commit that referenced this pull request Nov 24, 2016
macros: improve resolution performance

Avoid quadratic legacy macro name resolution in more cases.
r? @nrc
@bors bors merged commit cbe4787 into rust-lang:master Nov 25, 2016
@jseyfried jseyfried deleted the improve_macro_resolution_perf branch December 6, 2016 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants