don't rebuild alloc_jemalloc if jemalloc's .git directory has changed #38111
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -75,6 +75,10 @@ fn main() { | |||
| if entry.file_type().unwrap().is_dir() { | |||
| stack.extend(path.read_dir().unwrap().map(|e| e.unwrap())); | |||
There was a problem hiding this comment.
Perhaps we could just filter this iterator to strip everything that's .git?
the .git directory is modified by `bootstrap` when it updates this git submodule; this triggered rebuilds every time `bootstrap` was called. likely fixes rust-lang#38094
|
Simplified the logic. |
|
@bors: r+ |
|
📌 Commit acad8cc has been approved by |
don't rebuild alloc_jemalloc if jemalloc's .git directory has changed the .git directory is modified by `bootstrap` when it updates this git submodule; this triggered rebuilds every time `bootstrap` was called. likely fixes #38094 r? @alexcrichton
the .git directory is modified by
bootstrapwhen it updates this gitsubmodule; this triggered rebuilds every time
bootstrapwas called.likely fixes #38094
r? @alexcrichton