Add Debug to OpenOptions and DirBuilder #38577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ |
|
📌 Commit 9f9489b has been approved by |
|
Why does this commit touch |
|
@shepmaster - my mistake, it should have been seperate but is critical nonetheless. The mkdir call on Redox should use cloexec to avoid threads from handing over directory references if they are to call exec at the same time another is calling mkdir |
|
⌛ Testing commit 9f9489b with merge 86896ba... |
bors
added a commit
that referenced
this pull request
Dec 27, 2016
Add Debug to OpenOptions and DirBuilder This fixes the build on Redox as the platform independent structs now implement Debug.
|
☀️ Test successful - status-appveyor, status-travis |
|
Thanks @alexcrichton! |
bors
added a commit
that referenced
this pull request
Dec 28, 2016
Fix argument handling on Redox After switching the start code to be handled in libc, we are no longer passing in slices as arguments into the libstd main function. This means that handling had to be rewritten to match the unix way of doing things. Additional commits on this branch are going to be merged in this PR: #38577 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the build on Redox as the platform independent structs now implement Debug.