rustbuild: Implement DESTDIR support #38654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit primarily starts supporting the `DESTDIR` environment variable like the old build system. Along the way this brings `config.toml` up to date with support in `config.mk` with install options supported. Closes rust-lang#38441
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit 16f8372 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 12, 2017
rustbuild: Implement DESTDIR support This commit primarily starts supporting the `DESTDIR` environment variable like the old build system. Along the way this brings `config.toml` up to date with support in `config.mk` with install options supported. Closes #38441
|
☀️ Test successful - status-appveyor, status-travis |
|
Any chance to get this backported to 1.15? |
alexcrichton
added
the
beta-nominated
alexcrichton
removed
the
beta-nominated
|
Unfortunately we missed the deadline to do backports, so this'll make its way into 1.16 |
|
@alexcrichton I see it's not in the beta yet and the beta-nominated tag is gone. |
|
@Keruspe this PR is now on beta, those tags were for the previous 1.15.0 beta, but we didn't get it out in time for that |
|
Indeed, either I failed my pull or did so before it hit beta, sorry for the noise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit primarily starts supporting the
DESTDIRenvironment variable likethe old build system. Along the way this brings
config.tomlup to date withsupport in
config.mkwith install options supported.Closes #38441