Some i128 tests #38767
Some i128 tests #38767
Conversation
est31
commented
Jan 1, 2017
est31
commented
- Add some FFI tests for i128 on architectures where we have sort of working "C" FFI support. On all other architectures we ignore the test.
- enhance the u128 overflow tests
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
The makefile looks a bit contrived, but its the only way (the compiletest tool doesn't set stage0 or "windows" cfg's). |
| @@ -0,0 +1,30 @@ | |||
| // Copyright 2017 The Rust Project Developers. See the COPYRIGHT | |||
There was a problem hiding this comment.
Just use the rust_test_helpers.c file that we have precisely for the C FFI testing.
There was a problem hiding this comment.
This test then can become a plain run-pass one.
|
Okay, no more makefiles, thanks to @nagisa |
|
@bors r+ |
|
📌 Commit 620027c has been approved by |
|
⌛ Testing commit 620027c with merge 3fb46f9... |
|
💔 Test failed - status-travis |
|
The error seems to be relevant. |
|
Okay, I think I've fixed it now. Also, the 128 ffi test got a comment about why its ignored on windows. r? @eddyb |
|
@bors r+ |
|
📌 Commit 28f6d4a has been approved by |
Some i128 tests * Add some FFI tests for i128 on architectures where we have sort of working "C" FFI support. On all other architectures we ignore the test. * enhance the u128 overflow tests
|
☀️ Test successful - status-appveyor, status-travis |
