trans: Fix missing closure env drop-glue in trans-item collector. #38822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
approved these changes
Jan 4, 2017
|
@bors r+ |
|
📌 Commit ab8fff2 has been approved by |
|
@eddyb I just pushed a commit with an additional fix. Could you please review that too? |
|
@bors r+ |
|
📌 Commit 8b94267 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 8, 2017
trans: Fix missing closure env drop-glue in trans-item collector. FnOnce adapters automatically generated by the compiler introduce a call to drop the closure environment. The collector didn't pick up on that because this drop call does not show up in MIR. That could lead to an assertion being triggered if the drop-glue for the environment wasn't instantiated via something else. Fixes #38810 cc @arielb1 r? @eddyb or @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
|
@michaelwoerister, @eddyb |
|
The main reason is that the failure cannot show up with the current CGU partitioning scheme, only with different scheme I have in a local branch. But I'll try to come up with a test case once that scheme gets merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FnOnce adapters automatically generated by the compiler introduce a call to drop the closure environment. The collector didn't pick up on that because this drop call does not show up in MIR. That could lead to an assertion being triggered if the drop-glue for the environment wasn't instantiated via something else.
Fixes #38810
cc @arielb1
r? @eddyb or @nikomatsakis