Skip to content

Don't generate doc if doc comments only filled with 'white' characters #39340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2017

Conversation

GuillaumeGomez
Copy link
Member

Fixes #39339.

r? @steveklabnik

cc @rust-lang/docs

debug!("docblock: ==============\n{:?}\n=======", text);
let rendered = if lang.is_null() {
let rendered = if lang.is_null() || origtext.len() == 0 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: origtex.is_empty()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

@GuillaumeGomez
Copy link
Member Author

Updated.

@frewsxcv
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 28, 2017

📌 Commit 460a3b2 has been approved by frewsxcv

@bors
Copy link
Collaborator

bors commented Jan 28, 2017

⌛ Testing commit 460a3b2 with merge 010c3e2...

bors added a commit that referenced this pull request Jan 28, 2017
Don't generate doc if doc comments only filled with 'white' characters

Fixes #39339.

r? @steveklabnik

cc @rust-lang/docs
@bors
Copy link
Collaborator

bors commented Jan 28, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: frewsxcv
Pushing 010c3e2 to master...

@bors bors merged commit 460a3b2 into rust-lang:master Jan 28, 2017
@GuillaumeGomez GuillaumeGomez deleted the empty_comment branch January 28, 2017 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants