Skip to content

Minor grammatical edits; use preferred nomenclature consistently. #3947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Minor grammatical edits; use preferred nomenclature consistently. #3947

wants to merge 1 commit into from

Conversation

catseye
Copy link

@catseye catseye commented Nov 11, 2012

This change fixes a few things in the tutorial. Aside from the obvious minor grammatical edits:

  • It seems odd to list curl as a dependency and then recommend using wget to grab the tarball. Changed the command to curl -O.
  • The list of basic arithmetic operations was a mix of parts of speech; they are now all imperative verbs.
  • The tutorial has a section about the preferred terminology for the kinds of pointers, but subsequently occasionally uses the non-preferred terms "shared box" and "unique box"; these have been changed to "managed box" and "owned box".

@vertexclique
Copy link
Member

Yes I saw the wget think and I forgot the fix.

Mahmut Bulut
11 Kas 2012 18:29 tarihinde "catseye" [email protected] yazdý:

This change fixes a few things in the tutorial. Aside from the obvious
minor grammatical edits:

  • It seems odd to list curl as a dependency and then recommend using
    wget to grab the tarball. Changed the command to curl -O.
  • The list of basic arithmetic operations was a mix of parts of
    speech; they are now all imperative verbs.
  • The tutorial has a section about the preferred terminology for the
    kinds of pointers, but subsequently occasionally uses the non-preferred
    terms "shared box" and "unique box"; these have been changed to "managed
    box" and "owned box".

You can merge this Pull Request by running:

git pull https://github.com/catseye/rust tutorial-grammar-fixes

Or view, comment on, or merge it at:

#3947
Commit Summary

  • Minor grammatical edits; use preferred nomenclature consistently.

File Changes

  • M doc/tutorial.md (34)

Patch Links

@brson
Copy link
Contributor

brson commented Nov 13, 2012

Thanks! Is 'Cat's Eye Technologies' how you want to be listed in AUTHORS.txt?

@catseye
Copy link
Author

catseye commented Nov 13, 2012

Please list me as Chris Pressey. (I should probably convert this account to an organization at some point...) Thanks.

@brson brson closed this Nov 13, 2012
@graydon
Copy link
Contributor

graydon commented Nov 13, 2012

Thanks! Landing on incoming (in the future, please target changes at incoming branch, not master)

What email adress should we put next to your name?

@catseye
Copy link
Author

catseye commented Nov 14, 2012

Thanks, I'll remember that. Please use the email address in the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants