Skip to content

rustbuild: Fix a bug when manifesting with Cargo #40443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2017

Conversation

alexcrichton
Copy link
Member

The wrong Cargo version was passed down so it ended up panicking the
build-manifest script as it couldn't find the right tarball.

The wrong Cargo version was passed down so it ended up panicking the
build-manifest script as it couldn't find the right tarball.
@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

@bors: r+ p=2

I'm gonna go ahead an r+ this so we can hopefully get new nightlies soon, but @brson if you have comments I certainly don't mind doing follow up PRs/commits.

@bors
Copy link
Collaborator

bors commented Mar 11, 2017

📌 Commit 8db566e has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Mar 11, 2017

⌛ Testing commit 8db566e with merge e4eb964...

bors added a commit that referenced this pull request Mar 11, 2017
rustbuild: Fix a bug when manifesting with Cargo

The wrong Cargo version was passed down so it ended up panicking the
build-manifest script as it couldn't find the right tarball.
@bors
Copy link
Collaborator

bors commented Mar 11, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing e4eb964 to master...

@bors bors merged commit 8db566e into rust-lang:master Mar 11, 2017
@alexcrichton alexcrichton deleted the fix-nightlies-again branch March 17, 2017 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants