Tiny update to rustdoc CSS #40719
Tiny update to rustdoc CSS #40719
Conversation
Just makes trait bounds a bit less blaring.
|
Some changes occurred in HTML/CSS. |
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @frewsxcv (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
I can't find the difference. Could you add screenshot here (you can put images in comments on github) of before and after of the change please? |
|
very small diff with color |
|
That's what I saw from the diff yes, but I'd prefer to have both screenshot of before and after in order to have opinion on the style change itself. I think it'll be fine but I prefer to have every information. |
|
Oh, totally. Before: https://alopex.li/temp/rustdoc-normal-traits.png After: https://alopex.li/temp/rustdoc-small-traits.png Side-by-side, new on right: https://alopex.li/temp/rustdoc-comparison2.png It just makes the trait text a little smaller and a little lighter. I feel sort of silly making such a small PR, but... |
To be clear, we love small PRs. Small PRs are easier to understand, and you can get a lot done with a number of small PRs over time. Don't worry about it 😄 |
|
+1 for small PRs, so much easier to review than large PRs, open as many as you want :) Regarding the changes in the pull request in this PR, I'm +0. I can see why it might look better, but it seems like the second lines in the function declarations (the ones that got lighter in this PR) are just as important as the first. Both lines make up the entire function declaration. I don't feel strongly about this though. |
|
I find the new color not black enough. Thoughts @rust-lang/docs? |
|
@rfcbot reviewed |
Mark-Simulacrum
added
the
S-waiting-on-team
|
The |
|
Very good point @neosilky! |
arielb1
added
the
A-docs
|
Is the docs team looking at this? |
|
It seems not. Still waiting for their opinions. cc @rust-lang/docs |
This is how I feel too. |
|
I like these changes because they give the function names more focus. So it's easier to scroll through a lot of functions to find the one you need. And once you found the function, it's still easy enough to focus on the trait bounds. |
|
I wanted to see how this interacted with the changes to where clause rendering that landed since this was opened:
|
|
Ok, the @rust-lang/docs accepted this PR. Just add the missing ';' for the color property please, then we're merging it. Thanks! |
Mark-Simulacrum
added
S-waiting-on-author
| @@ -378,6 +378,8 @@ h4 > code, h3 > code, .invisible > code { | |||
| .content .fn .where, | |||
| .content .where.fmt-newline { | |||
| display: block; | |||
| color: #4E4C4C | |||
|
This PR is almost ready for merging, we are just waiting for you to add the semicolon! |
|
Going to close this for now. If you get around to addressing this @icefoxen, feel free to open a new PR, thanks! |
|
@frewsxcv Shall I submit the new PR? |
Update to trait bounds CSS in rustdoc Fixed re-submission of #40719.
Just makes trait bounds a bit less blaring. I find it decreases the noise in the common case when I'm not terribly interested in them, while making them still easily visible when I am. Example screenshot here: https://alopex.li/temp/rustdoc-small-traits.png
Not sure if anyone besides me cares about this, but... 😄