Fix definitions of ULONG_PTR #41787
Fix definitions of ULONG_PTR #41787
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors: r+ |
|
📌 Commit db8be04 has been approved by |
Fix definitions of ULONG_PTR The Windows type `ULONG_PTR` is supposed to be equivalent to `usize`, but several parts of the codebase currently define it as `u64`. Evidently this hasn't broken anything yet but it might cause annoying 32-bit-specific breakage in future. See https://msdn.microsoft.com/en-gb/library/windows/desktop/aa383751(v=vs.85).aspx r? @alexcrichton
Mark-Simulacrum
added
the
S-waiting-on-bors
|
☀️ Test successful - status-appveyor, status-travis |
The Windows type
ULONG_PTRis supposed to be equivalent tousize, but several parts of the codebase currently define it asu64. Evidently this hasn't broken anything yet but it might cause annoying 32-bit-specific breakage in future.See https://msdn.microsoft.com/en-gb/library/windows/desktop/aa383751(v=vs.85).aspx
r? @alexcrichton