Add note regarding parent module containing use statement. #42283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
kennytm
reviewed
May 28, 2017
src/librustc_resolve/diagnostics.rs
Outdated
| `use super::File;` which will import the types from the parent namespace. An | ||
| example that causes this error is below: | ||
|
|
||
| ``` |
|
|
||
| mod foo { | ||
| // either | ||
| use super::File; |
There was a problem hiding this comment.
Currently CI failed with
[00:55:49] ---- /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index (line 6486) stdout ----
[00:55:49] error[E0432]: unresolved import `super::File`
[00:55:49] --> <anon>:6:9
[00:55:49] |
[00:55:49] 6 | use super::File;
[00:55:49] | ^^^^^^^^^^^ no `File` in the root
Dunno why, probably workaround it by adding a hidden # pub above the use std::fs::File?
There was a problem hiding this comment.
The problem here was that rustdoc auto-injects fn main surrounding this, so it was correct -- there was no File in root. I inserted an empty commented fn main to workaround this, so we should be fine now.
Mark-Simulacrum
force-pushed
the
issue-40341
branch
from
b9d7fb3 to
c85a8fb
Compare
carols10cents
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit c85a8fb has been approved by |
bors
added a commit
that referenced
this pull request
May 30, 2017
Add note regarding parent module containing use statement. Fixes #40341.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40341.