Change llvm.neon.* to llvm.arm.neon.* in the mapping for platform intrinsics
#42500
Conversation
… intrinsics This avoids linker errors when using platform intrinsics on 32-bit ARM with NEON. Fixes hsivonen/simd#10.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
LGTM. r? @japaric |
|
📌 Commit 0fb8414 has been approved by |
aidanhs
added
the
S-waiting-on-bors
Change `llvm.neon.*` to `llvm.arm.neon.*` in the mapping for platform intrinsics This avoids linker errors when using platform intrinsics on 32-bit ARM with NEON. Fixes hsivonen/simd#10. I don't have an explanation why the old code might have worked when the `simd` crate was written, since the new LLVM intrinsic naming seems to have existed as early as 2012. Maybe LLVM accepted two naming schemes for a few years and dropped the `llvm.neon.*` version recently? I don't know. Also, I don't know how to write a unit test for this.
|
☀️ Test successful - status-appveyor, status-travis |
This avoids linker errors when using platform intrinsics on 32-bit ARM with
NEON.
Fixes hsivonen/simd#10.
I don't have an explanation why the old code might have worked when the
simdcrate was written, since the new LLVM intrinsic naming seems to have existed as early as 2012. Maybe LLVM accepted two naming schemes for a few years and dropped thellvm.neon.*version recently? I don't know.Also, I don't know how to write a unit test for this.