Only emit one error for use foo::self;
#42580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
tommyip
commented
Jun 10, 2017
| @@ -11,4 +11,7 @@ | |||
| use foo::self; //~ ERROR unresolved import `foo::self` | |||
There was a problem hiding this comment.
I guess if foo is invalid we should still have both errors?
There was a problem hiding this comment.
I don't think it makes sense to improve errors in this area, all examples from #42559 should be legal anyway, I'll try to submit a PR somewhere after June 17.
|
r? @jseyfried or @petrochenkov |
|
@bors r+ |
|
📌 Commit 4640f4d has been approved by |
|
⌛ Testing commit 4640f4d with merge 5b5fcca... |
Currently `use foo::self;` would emit both E0429 and E0432. This commit silence the latter one (assuming `foo` is a valid module). Fixes rust-lang#42559
|
Fixed the tests |
|
@bors r+ |
|
📌 Commit b89db83 has been approved by |
bors
added a commit
that referenced
this pull request
Jun 10, 2017
Only emit one error for `use foo::self;` Currently `use foo::self;` would emit both E0429 and E0432. This commit silence the latter one (assuming `foo` is a valid module). Fixes #42559
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
use foo::self;would emit both E0429 and E0432. This commit silence the latter one (assumingfoois a valid module).Fixes #42559