Use --depth to speed up pristine submodule cloning #42665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I expect this to save us 5-7min on OSX builds. |
src/ci/init_repo.sh
Outdated
|
|
||
| travis_fold start update_cache | ||
| travis_time_start | ||
|
|
||
| # Update the cache (a pristine copy of the rust source master) | ||
| if [ ! -d "$cache_src_dir/.git" ]; then | ||
| retry sh -c "rm -rf $cache_src_dir && mkdir -p $cache_src_dir && \ | ||
| git clone https://github.com/rust-lang/rust.git $cache_src_dir" | ||
| git clone --depth 1 https://github.com/rust-lang/rust.git $cache_src_dir" | ||
| fi | ||
| retry sh -c "cd $cache_src_dir && git reset --hard && git pull" |
There was a problem hiding this comment.
git pull here I think will make us no longer have a depth of 1 anyway, but I'm not sure. https://stackoverflow.com/questions/19352894/how-to-git-fetch-efficiently-from-a-shallow-clone
There was a problem hiding this comment.
Oops, I have some other changes I didn't push.
In addition, remove all the unused cache stuff
aidanhs
force-pushed
the
aphs-simplify-init-repos
branch
from
e8264a4 to
d0c1e64
Compare
|
I'll wait for Travis, but looks good to me overall. |
aidanhs
added
the
S-waiting-on-review
|
@bors r+ p=1 Setting higher priority since this helps with OS X timeouts (at least a little). Looks like this passed the cache stage in Travis. |
|
📌 Commit d0c1e64 has been approved by |
bors
added a commit
that referenced
this pull request
Jun 15, 2017
…acrum Use --depth to speed up pristine submodule cloning In addition, remove all the unused cache stuff r? @Mark-Simulacrum
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, remove all the unused cache stuff
r? @Mark-Simulacrum