rustdoc: Fix a few issues with associated consts #42865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ollie27
commented
Jun 23, 2017
ollie27
commented
- Make sure private consts are stripped.
- Don't show a code block for the value if there is none.
- Make sure default values are shown in impls.
- Make sure docs from the trait are used if the impl has no docs.
* Make sure private consts are stripped. * Don't show a code block for the value if there is none. * Make sure default values are shown in impls. * Make sure docs from the trait are used if the impl has no docs.
|
r? @frewsxcv (rust_highfive has picked a reviewer for you, use r? to override) |
frewsxcv
added
the
T-dev-tools
Mark-Simulacrum
added
the
S-waiting-on-review
|
Thanks! @bors: r+ |
|
📌 Commit 4488f9b has been approved by |
bors
added a commit
that referenced
this pull request
Jun 25, 2017
rustdoc: Fix a few issues with associated consts * Make sure private consts are stripped. * Don't show a code block for the value if there is none. * Make sure default values are shown in impls. * Make sure docs from the trait are used if the impl has no docs.
|
💔 Test failed - status-travis |
|
@bors retry os x timed out |
bors
added a commit
that referenced
this pull request
Jun 25, 2017
rustdoc: Fix a few issues with associated consts * Make sure private consts are stripped. * Don't show a code block for the value if there is none. * Make sure default values are shown in impls. * Make sure docs from the trait are used if the impl has no docs.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.