Refactor pretty printing slightly #42897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
Aaaand one of the osx builds did that thing where it doesn't start :( Restarting it... |
carols10cents
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #42902) made this pull request unmergeable. Please resolve the merge conflicts. |
aidanhs
added
S-waiting-on-author
|
@Mark-Simulacrum looks like this has conflicts that need resolving |
|
Okay, well, I resolved the conflicts but still need to rebase the branch -- I'll leave it as-is until I get a chance to do that... |
Mark-Simulacrum
added
S-waiting-on-review
Mark-Simulacrum
force-pushed
the
pretty-print-refactor
branch
from
ccee223 to
75ce1b2
Compare
|
☔ The latest upstream changes (presumably #43115) made this pull request unmergeable. Please resolve the merge conflicts. |
arielb1
added
S-waiting-on-author
No (intentional) changes to behavior. This is intended to avoid the anti-pattern of having to import individual methods throughout code.
The literal index was increased in only next_lit, so it isn't necessary: code now uses an iterator. The cur_cmnt field is also moved to be increased in print_comment instead of after each call to print_comment.
This is needless noise; the closure we take is FnOnce, so move || {} is
fine to pass other parameters necessary.
Mark-Simulacrum
force-pushed
the
pretty-print-refactor
branch
from
75ce1b2 to
40f03a1
Compare
|
Rebased. |
Mark-Simulacrum
added
S-waiting-on-review
|
r? @jseyfried |
|
Nice! |
|
📌 Commit 40f03a1 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 12, 2017
…ried Refactor pretty printing slightly This doesn't introduce any functional changes (that I'm aware of). The primary intention here is to clean up the code a little. Each commit is intended to stand alone, reviewing commit-by-commit may be easiest.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't introduce any functional changes (that I'm aware of). The primary intention here is to clean up the code a little. Each commit is intended to stand alone, reviewing commit-by-commit may be easiest.