rustbuild: Tweak how we cross-compile LLVM #43527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for upgrading to LLVM 5.0 it looks like we need to tweak how we cross compile LLVM slightly. It's using `CMAKE_SYSTEM_NAME` to infer whether to build libFuzzer which only works on some platforms, and then once we configure that it needs to apparently reach into the host build area to try to compile `llvm-config` as well. Once these are both configured, though, it looks like we can successfully cross-compile LLVM.
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
cc @TimNN |
|
Do we need any checks for LLVM 5.0 around the new variables? Presumably no, since they seem like they'd work either way, but it'd be good to check (CI will take care of that though). Otherwise r=me. |
|
Yeah I'm hoping that this is ok to land with 4.0 we've got now, but failing that CI will complain at me and we can just check this in with the final 5.0 PR. It's just kinda cool if the 5.0 PR is literally just updating the submodule :) @bors: r=Mark-Simulacrum |
|
📌 Commit 069a1b3 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 29, 2017
…lacrum rustbuild: Tweak how we cross-compile LLVM In preparation for upgrading to LLVM 5.0 it looks like we need to tweak how we cross compile LLVM slightly. It's using `CMAKE_SYSTEM_NAME` to infer whether to build libFuzzer which only works on some platforms, and then once we configure that it needs to apparently reach into the host build area to try to compile `llvm-config` as well. Once these are both configured, though, it looks like we can successfully cross-compile LLVM.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for upgrading to LLVM 5.0 it looks like we need to tweak how we
cross compile LLVM slightly. It's using
CMAKE_SYSTEM_NAMEto infer whether tobuild libFuzzer which only works on some platforms, and then once we configure
that it needs to apparently reach into the host build area to try to compile
llvm-configas well. Once these are both configured, though, it looks like wecan successfully cross-compile LLVM.