feature error span on attribute for fn_must_use, SIMD/align reprs, macro reëxport #44111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
(Delegating my compile-fail testing to Travis; I'll force push afterwards.) |
zackmdavis
force-pushed
the
feature_attr_error_span
branch
from
a2eea09 to
df1676a
Compare
|
update; one of the compile-fail tests still broken 😞 ; I may not have time to fix it for a few days |
zackmdavis
force-pushed
the
feature_attr_error_span
branch
from
df1676a to
a7df17a
Compare
There were several feature-gated attributes for which the feature-not-available error spans would point to the item annotated with the gated attribute, when it would make more sense for the span to point to the attribute itself: if the attribute is removed, the function/struct/&c. likely still makes sense and the program will compile. (Note that we decline to make the analogous change for the `main`, `start`, and `plugin_registrar` features, for in those cases it makes sense for the span to implicate the entire function, of which there is little hope of using without the gated attribute.)
zackmdavis
force-pushed
the
feature_attr_error_span
branch
from
a7df17a to
8bb2946
Compare
carols10cents
added
the
S-waiting-on-review
nikomatsakis
approved these changes
Aug 28, 2017
|
@bors r+ Nice! |
|
📌 Commit 8bb2946 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 29, 2017
…akis feature error span on attribute for fn_must_use, SIMD/align reprs, macro reëxport There were several feature-gated attributes for which the feature-not-available error spans would point to the item annotated with the gated attribute, when it would make more sense for the span to point to the attribute itself: if the attribute is removed, the function/struct/_&c._ likely still makes sense and the program will compile. (Note that we decline to make the analogous change for the `main`, `start`, and `plugin_registrar` features, for in those cases it makes sense for the span to implicate the entire function, of which there is little hope of using without the gated attribute.) 
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several feature-gated attributes for which the feature-not-available
error spans would point to the item annotated with the gated attribute, when it
would make more sense for the span to point to the attribute itself: if the
attribute is removed, the function/struct/&c. likely still makes sense and the
program will compile. (Note that we decline to make the analogous change for
the
main,start, andplugin_registrarfeatures, for in those cases itmakes sense for the span to implicate the entire function, of which there is
little hope of using without the gated attribute.)