Allow Drop types in const's too, with #![feature(drop_types_in_const)]. #44212

eddyb · 2017-08-31T09:22:50Z

Implements the remaining amendment, see #33156. cc @SergioBenitez

SergioBenitez · 2017-08-31T09:34:20Z

src/test/compile-fail/static-drop-scope.rs

 //~^ ERROR statics are not allowed to have destructors

+const EARLY_DROP_C: i32 = (WithDtor, 0).1;
+//~^ ERROR constants are not allowed to have destructors


This error message is confusing since constants are allowed to have destructors. Instead, they're not allowed to require destruction upon use. The error message should be changed to clarify the issue.

maybe "not allowed to execute destructors"?

Please leave a comment on #33156 instead, to do so when stabilizing the feature.

I was directing that at @SergioBenitez FWIW, github didn't update, but thanks for updating the issue description!

nikomatsakis

Left a suggestion for a test -- are there other edge cases to consider? Otherwise seems pretty clean!

nikomatsakis · 2017-09-01T19:19:24Z

src/test/run-pass/issue-34053.rs

@@ -17,7 +17,14 @@ impl Drop for A {
 }


I feel like we need a test that demonstrates the runtime semantics of constants with DROP. In particular, the destructor does execute when you (e.g.) access BAR or A::BAZ, right?

I want some test that shows when the destructor runs and tests that it did indeed execute (i.e., by observing some effect it had on a global counter).

Ah, right, this was the odd thing about the RFC amendment.

nikomatsakis · 2017-09-05T14:25:42Z

@bors r+

bors · 2017-09-05T14:25:43Z

📌 Commit 1d5c0ba has been approved by nikomatsakis

bors · 2017-09-07T10:28:21Z

⌛ Testing commit 1d5c0ba with merge af440b1553833cf28debb302d1c7a38ec60e64d2...

bors · 2017-09-07T10:50:15Z

💔 Test failed - status-travis

kennytm · 2017-09-07T11:03:32Z

@bors retry #40474

x86_64-gnu-incremental failed, crates.io responses with 503.

[00:06:17]  Downloading unicode-segmentation v1.2.0
[00:07:17] warning: spurious network error (2 tries remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
[00:07:47] warning: spurious network error (1 tries remaining): failed to get 200 response from `https://crates.io/api/v1/crates/unicode-segmentation/1.2.0/download`, got 503
[00:08:17] error: unable to get packages from source
[00:08:17] 
[00:08:17] Caused by:
[00:08:17]   failed to get 200 response from `https://crates.io/api/v1/crates/unicode-segmentation/1.2.0/download`, got 503
[00:08:17] thread 'main' panicked at 'command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "metadata" "--format-version" "1" "--manifest-path" "/checkout/src/libstd/Cargo.toml"
[00:08:17] expected success, got: exit code: 101', /checkout/src/build_helper/lib.rs:137:8
[00:08:17] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:08:17] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build nonexistent/path/to/trigger/cargo/metadata
[00:08:17] Build completed unsuccessfully in 0:03:33
[00:08:17] Makefile:77: recipe for target 'prepare' failed
[00:08:17] make: *** [prepare] Error 1
[00:08:17] Command failed. Attempt 3/5:
[00:08:17]     Finished dev [unoptimized] target(s) in 0.0 secs
[00:08:18] warning: Package `toml v0.4.5` does not have feature `serde`. It has a required dependency with that name, but only optional dependencies can be used as features. This is currently a warning to ease the transition, but it will become an error in the future.
[00:08:18]  Downloading clap v2.26.0
[00:08:18]  Downloading memchr v0.1.11
[00:08:18]  Downloading debug_unreachable v0.1.1
[00:08:49]  Downloading mac v0.1.1
[00:08:49]  Downloading bitflags v0.9.1
[00:09:49] warning: spurious network error (2 tries remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
[00:09:49]  Downloading strsim v0.6.0
[00:10:50] warning: spurious network error (2 tries remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
[00:10:50]  Downloading unicode-xid v0.0.3
[00:11:20]  Downloading kuchiki v0.5.1
[00:12:21] warning: spurious network error (2 tries remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
[00:12:51] warning: spurious network error (1 tries remaining): failed to get 200 response from `https://crates.io/api/v1/crates/kuchiki/0.5.1/download`, got 503
[00:13:21] error: unable to get packages from source
[00:13:21] 
[00:13:21] Caused by:
[00:13:21]   [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
[00:13:21] thread 'main' panicked at 'command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "metadata" "--format-version" "1" "--manifest-path" "/checkout/src/libstd/Cargo.toml"
[00:13:21] expected success, got: exit code: 101', /checkout/src/build_helper/lib.rs:137:8
[00:13:21] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:13:21] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build nonexistent/path/to/trigger/cargo/metadata
[00:13:21] Build completed unsuccessfully in 0:05:03
[00:13:21] make: *** [prepare] Error 1
[00:13:21] Makefile:77: recipe for target 'prepare' failed
[00:13:21] Command failed. Attempt 4/5:
[00:13:21]     Finished dev [unoptimized] target(s) in 0.0 secs
[00:13:21] warning: Package `toml v0.4.5` does not have feature `serde`. It has a required dependency with that name, but only optional dependencies can be used as features. This is currently a warning to ease the transition, but it will become an error in the future.
[00:13:21]  Downloading pest v0.3.3
[00:13:22]  Downloading unicode-bidi v0.3.4
[00:14:22] warning: spurious network error (2 tries remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
[00:14:52] warning: spurious network error (1 tries remaining): failed to get 200 response from `https://crates.io/api/v1/crates/unicode-bidi/0.3.4/download`, got 503
[00:15:22] error: unable to get packages from source
[00:15:22] 
[00:15:22] Caused by:
[00:15:22]   failed to get 200 response from `https://crates.io/api/v1/crates/unicode-bidi/0.3.4/download`, got 503
[00:15:22] thread 'main' panicked at 'command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "metadata" "--format-version" "1" "--manifest-path" "/checkout/src/libstd/Cargo.toml"
[00:15:22] expected success, got: exit code: 101', /checkout/src/build_helper/lib.rs:137:8
[00:15:22] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:15:22] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build nonexistent/path/to/trigger/cargo/metadata
[00:15:22] Build completed unsuccessfully in 0:02:01
[00:15:22] make: *** [prepare] Error 1
[00:15:22] Makefile:77: recipe for target 'prepare' failed
[00:15:22] Command failed. Attempt 5/5:
[00:15:23]     Finished dev [unoptimized] target(s) in 0.0 secs
[00:15:23] warning: Package `toml v0.4.5` does not have feature `serde`. It has a required dependency with that name, but only optional dependencies can be used as features. This is currently a warning to ease the transition, but it will become an error in the future.
[00:15:23]  Downloading handlebars v0.26.2
[00:15:53] warning: spurious network error (2 tries remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
[00:16:23] warning: spurious network error (1 tries remaining): failed to get 200 response from `https://crates.io/api/v1/crates/handlebars/0.26.2/download`, got 503
[00:16:53] error: unable to get packages from source
[00:16:53] 
[00:16:53] Caused by:
[00:16:53]   failed to get 200 response from `https://crates.io/api/v1/crates/handlebars/0.26.2/download`, got 503
[00:16:53] thread 'main' panicked at 'command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "metadata" "--format-version" "1" "--manifest-path" "/checkout/src/libstd/Cargo.toml"
[00:16:53] expected success, got: exit code: 101', /checkout/src/build_helper/lib.rs:137:8
[00:16:53] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:16:53] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build nonexistent/path/to/trigger/cargo/metadata
[00:16:53] Build completed unsuccessfully in 0:01:30
[00:16:53] Makefile:77: recipe for target 'prepare' failed
[00:16:53] make: *** [prepare] Error 1
[00:16:53] The command has failed after 5 attempts.

bors · 2017-09-07T12:06:03Z

⌛ Testing commit 1d5c0ba with merge c760aa74070fd08cf53008dc7c25928f813bc918...

bors · 2017-09-07T13:06:08Z

💔 Test failed - status-travis

kennytm · 2017-09-07T13:19:46Z

@bors retry Travis's problem https://www.traviscistatus.com/incidents/4qylrqvy50gy

bors · 2017-09-07T20:13:10Z

⌛ Testing commit 1d5c0ba with merge 8d30e7d87e56eec1aa1d1a7687ac4ba01ae0ebbb...

bors · 2017-09-07T20:53:45Z

💔 Test failed - status-travis

alexcrichton · 2017-09-07T20:54:14Z

@bors: retry

prioritizing travis: Downgrade to previous images temporarily #44399 so this can land

bors · 2017-09-08T14:42:33Z

⌛ Testing commit 1d5c0ba with merge 2e2b1fe...

@SergioBenitez

Allow Drop types in const's too, with #![feature(drop_types_in_const)]. Implements the remaining amendment, see #33156. cc @SergioBenitez r? @nikomatsakis

bors · 2017-09-08T23:47:13Z

💔 Test failed - status-travis

alexcrichton · 2017-09-09T00:39:10Z

@bors: retry

the reason we all think it is

bors · 2017-09-09T11:49:04Z

⌛ Testing commit 1d5c0ba with merge 18366f4...

@SergioBenitez

Allow Drop types in const's too, with #![feature(drop_types_in_const)]. Implements the remaining amendment, see #33156. cc @SergioBenitez r? @nikomatsakis

bors · 2017-09-09T14:20:22Z

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 18366f4 to master...

rust-highfive assigned nikomatsakis Aug 31, 2017

SergioBenitez reviewed Aug 31, 2017

View reviewed changes

nikomatsakis mentioned this pull request Aug 31, 2017

permit Drop types in constants (tracking issue for RFC #1440) #33156

Closed

2 tasks

eddyb force-pushed the drop-const branch 3 times, most recently from 5854635 to 297a521 Compare September 1, 2017 06:06

nikomatsakis requested changes Sep 1, 2017

View reviewed changes

shepmaster added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 1, 2017

Allow Drop types in const's too, with #![feature(drop_types_in_const)].

1d5c0ba

eddyb force-pushed the drop-const branch from 297a521 to 1d5c0ba Compare September 2, 2017 06:08

eddyb added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 2, 2017

nikomatsakis approved these changes Sep 5, 2017

View reviewed changes

arielb1 added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2017

bors added a commit that referenced this pull request Sep 8, 2017

Auto merge of #44212 - eddyb:drop-const, r=nikomatsakis

2e2b1fe

Allow Drop types in const's too, with #![feature(drop_types_in_const)]. Implements the remaining amendment, see #33156. cc @SergioBenitez r? @nikomatsakis

bors added a commit that referenced this pull request Sep 9, 2017

Auto merge of #44212 - eddyb:drop-const, r=nikomatsakis

18366f4

Allow Drop types in const's too, with #![feature(drop_types_in_const)]. Implements the remaining amendment, see #33156. cc @SergioBenitez r? @nikomatsakis

bors merged commit 1d5c0ba into rust-lang:master Sep 9, 2017

eddyb deleted the drop-const branch September 9, 2017 14:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow Drop types in const's too, with #![feature(drop_types_in_const)]. #44212

Allow Drop types in const's too, with #![feature(drop_types_in_const)]. #44212

eddyb commented Aug 31, 2017

SergioBenitez Aug 31, 2017

nikomatsakis Aug 31, 2017

eddyb Aug 31, 2017

nikomatsakis Aug 31, 2017

eddyb Aug 31, 2017 •

edited

Loading

nikomatsakis left a comment

nikomatsakis Sep 1, 2017

eddyb Sep 1, 2017

nikomatsakis commented Sep 5, 2017

bors commented Sep 5, 2017

bors commented Sep 7, 2017

bors commented Sep 7, 2017

kennytm commented Sep 7, 2017

bors commented Sep 7, 2017

bors commented Sep 7, 2017

kennytm commented Sep 7, 2017

bors commented Sep 7, 2017

bors commented Sep 7, 2017

alexcrichton commented Sep 7, 2017

bors commented Sep 8, 2017

bors commented Sep 8, 2017

alexcrichton commented Sep 9, 2017

bors commented Sep 9, 2017

bors commented Sep 9, 2017

Allow Drop types in const's too, with #![feature(drop_types_in_const)]. #44212

Allow Drop types in const's too, with #![feature(drop_types_in_const)]. #44212

Conversation

eddyb commented Aug 31, 2017

SergioBenitez Aug 31, 2017

Choose a reason for hiding this comment

nikomatsakis Aug 31, 2017

Choose a reason for hiding this comment

eddyb Aug 31, 2017

Choose a reason for hiding this comment

nikomatsakis Aug 31, 2017

Choose a reason for hiding this comment

eddyb Aug 31, 2017 • edited Loading

Choose a reason for hiding this comment

nikomatsakis left a comment

Choose a reason for hiding this comment

nikomatsakis Sep 1, 2017

Choose a reason for hiding this comment

eddyb Sep 1, 2017

Choose a reason for hiding this comment

nikomatsakis commented Sep 5, 2017

bors commented Sep 5, 2017

bors commented Sep 7, 2017

bors commented Sep 7, 2017

kennytm commented Sep 7, 2017

bors commented Sep 7, 2017

bors commented Sep 7, 2017

kennytm commented Sep 7, 2017

bors commented Sep 7, 2017

bors commented Sep 7, 2017

alexcrichton commented Sep 7, 2017

bors commented Sep 8, 2017

bors commented Sep 8, 2017

alexcrichton commented Sep 9, 2017

bors commented Sep 9, 2017

bors commented Sep 9, 2017

eddyb Aug 31, 2017 •

edited

Loading