Provide the full span of method calls to check_argument_types

[goffrie]

... so that it includes the span of the passed arguments, not just the name of the called method.

Fixes #44760.

[rust-highfive]

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

[eddyb]

r? @oli-obk

[oli-obk]

You need to fix method-call-err-msg.rs , too. This will include the args on other errors, too. can you add examples of those errors as ui tests, so we know how they look now? Maybe just move method-call-err-msg.rs to ui tests

[goffrie]

I moved it to ui tests. I don't know if the new output is really great though, maybe it should just point at the parens

[oli-obk]

This is a definite regression. It used to produce

error[E0061]: this function takes 1 parameter but 0 parameters were supplied
  --> src/main.rs:15:7
   |
5  |      fn one(self, _: isize) -> Foo { self }
   |      -------------------------------------- defined here
...
15 |      .one()     //~ ERROR this function takes 1 parameter but 0 parameters were supplied
   |       ^^^ expected 1 parameter

And we really want to keep the old report

[goffrie]

updated to keep the old error message

[oli-obk]

Lgtm now. @eddyb can you r+?

[kennytm]

@bors r=oli-obk

[bors]

📌 Commit bb4d1ca has been approved by oli-obk

[bors]

⌛ Testing commit bb4d1ca with merge df095ce...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: oli-obk
Pushing df095ce to master...