-
Notifications
You must be signed in to change notification settings - Fork 13.3k
rustc: Add some more compatibility with AVX-512 #45528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
I'm holding on these ABI changes until @eddyb's PR lands |
Sure thing! |
(meta) I think there should be an S-waiting-on-another-PR (#45225?) tag 😛 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c&p bug, otherwise looks great
src/librustc_trans/llvm_util.rs
Outdated
"avx512dq\0", "avx512er\0", | ||
"avx512f\0", "avx512ifma\0", | ||
"avx512pf\0", "avx512vbmi\0", | ||
"avx512vl\0", "avx512vbmi\0"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avx512vbmi
is repeated twice here, and avx512vpopcntdq
is missing
☔ The latest upstream changes (presumably #45761) made this pull request unmergeable. Please resolve the merge conflicts. |
* Increase the maximum vector size in the ABI calculations to ensure that AVX-512 operands are immediates. * Add a few more `target_feature` matchings for AVX-512 features
ping @arielb1, thoughts on my previous comment? |
📌 Commit d3563bb has been approved by |
rustc: Add some more compatibility with AVX-512 * Increase the maximum vector size in the ABI calculations to ensure that AVX-512 operands are immediates. * Add a few more `target_feature` matchings for AVX-512 features
☀️ Test successful - status-appveyor, status-travis |
AVX-512 operands are immediates.
target_feature
matchings for AVX-512 features