Skip to content

rustc: Add some more compatibility with AVX-512 #45528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2017

Conversation

alexcrichton
Copy link
Member

  • Increase the maximum vector size in the ABI calculations to ensure that
    AVX-512 operands are immediates.
  • Add a few more target_feature matchings for AVX-512 features

@rust-highfive
Copy link
Contributor

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@arielb1
Copy link
Contributor

arielb1 commented Oct 25, 2017

I'm holding on these ABI changes until @eddyb's PR lands

@alexcrichton
Copy link
Member Author

Sure thing!

@kennytm kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 26, 2017
@kennytm
Copy link
Member

kennytm commented Oct 26, 2017

(meta) I think there should be an S-waiting-on-another-PR (#45225?) tag 😛

Copy link
Contributor

@gnzlbg gnzlbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c&p bug, otherwise looks great

"avx512dq\0", "avx512er\0",
"avx512f\0", "avx512ifma\0",
"avx512pf\0", "avx512vbmi\0",
"avx512vl\0", "avx512vbmi\0"];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexcrichton

avx512vbmi is repeated twice here, and avx512vpopcntdq is missing

@alexcrichton
Copy link
Member Author

@arielb1 this is blocking any experimentation with AVX-512 in the stdsimd repo and I think the conflict with #45225 is likely to be very minimal at worst? Could this perhaps land ahead of time? Or is that one getting ready to land?

@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 7, 2017
@bors
Copy link
Collaborator

bors commented Nov 10, 2017

☔ The latest upstream changes (presumably #45761) made this pull request unmergeable. Please resolve the merge conflicts.

* Increase the maximum vector size in the ABI calculations to ensure that
  AVX-512 operands are immediates.
* Add a few more `target_feature` matchings for AVX-512 features
@alexcrichton
Copy link
Member Author

ping @arielb1, thoughts on my previous comment?

@arielb1
Copy link
Contributor

arielb1 commented Nov 16, 2017

@alexcrichton

Sure, I just saw the PR title and was scared, and #45225 looks like it's being delayed.

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 16, 2017

📌 Commit d3563bb has been approved by arielb1

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2017
@bors
Copy link
Collaborator

bors commented Nov 16, 2017

⌛ Testing commit d3563bb with merge 481b42b...

bors added a commit that referenced this pull request Nov 16, 2017
rustc: Add some more compatibility with AVX-512

* Increase the maximum vector size in the ABI calculations to ensure that
  AVX-512 operands are immediates.
* Add a few more `target_feature` matchings for AVX-512 features
@bors
Copy link
Collaborator

bors commented Nov 16, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: arielb1
Pushing 481b42b to master...

@bors bors merged commit d3563bb into rust-lang:master Nov 16, 2017
@alexcrichton alexcrichton deleted the avx512 branch December 6, 2017 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants