[beta] Cargo does not remove [root] from lockfile with --frozen #45658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
the
S-waiting-on-review
|
@bors: r+ |
|
📌 Commit db38341 has been approved by |
kennytm
added
S-waiting-on-bors
|
@Mark-Simulacrum has this broken crater somehow? I wonder why we haven't caught this earlier then, the change about |
bors
added a commit
that referenced
this pull request
Oct 31, 2017
[beta] Cargo does not remove [root] from lockfile with --frozen Okey, this is supposed to be a backport of rust-lang/cargo#4687, but looks like beta cargo at rust-lang and beta cargo at cargo are different at the moment, hence the huge diff (one commit in the diffrence rewrote every single test file in Cargo) rust-lang: https://github.com/rust-lang/cargo/commits/463e850146e9454b8b953ff73772a35b286b58e7 cargo: https://github.com/rust-lang/cargo/commits/rust-1.22.0 r? @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
|
@matklad Well, the issue with crater is that we generated lockfiles on stable and then tried to use them with beta cargo, which failed, and means that we can't currently (before next beta) run crater on stable vs. beta. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okey, this is supposed to be a backport of rust-lang/cargo#4687, but looks like beta cargo at rust-lang and beta cargo at cargo are different at the moment, hence the huge diff (one commit in the diffrence rewrote every single test file in Cargo)
rust-lang: https://github.com/rust-lang/cargo/commits/463e850146e9454b8b953ff73772a35b286b58e7
cargo: https://github.com/rust-lang/cargo/commits/rust-1.22.0
r? @alexcrichton