Change "Types/modules" title of search tab to be more accurate #45898
Conversation
kennytm
added
the
S-waiting-on-review
GuillaumeGomez
added
T-rustdoc
|
Please remove the second commit (the merge one). Also, I don't like much the new name. Maybe others like it or have propositions? |
|
Sorry about the merge I'm new to this. I removed it. The search is done by name, so maybe "By name" would be better? Is there a way to get a consensus on the new name? |
|
"By name" sounds good to me too. |
|
@JRegimbal: It'll be debated if needed in the next docs meeting. If most like the name, then it'll get merged otherwise you'll be asked to update the name. |
|
Ah okay! |
|
☔ The latest upstream changes (presumably #45673) made this pull request unmergeable. Please resolve the merge conflicts. |
"Types/modules" doesn't properly describe the results since it includes other things whose name matches the search term.
shepmaster
added
S-waiting-on-team
|
Triage ping @rust-lang/docs and @steveklabnik — we haven't heard from y'all in over two weeks; would someone mind giving an update? |
|
We didn't talk about it yet, we will next weds for sure. |
|
We talked about this in today's docs team meeting, and decided to take the opportunity to tweak the naming in all the tabs, not just the main one. We settled on using "In Names", "In Parameters", and "In Return Types", in order. Can you change the tab names to those, instead? |
QuietMisdreavus
added
S-waiting-on-author
Tabs are "In Names", "In Parameters", and "In Return Types".
|
Excellent! Thanks so much! @bors r+ rollup |
|
📌 Commit 41df62c has been approved by |
Change "Types/modules" title of search tab to be more accurate From issue #45787. Used "In name" as per suggestion from @Seeker14491.
|
☀️ Test successful - status-appveyor, status-travis |
From issue #45787. Used "In name" as per suggestion from @Seeker14491.