Report a targeted note for generic parameters that are missing a trait bound #46403
Conversation
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -289,6 +289,11 @@ impl<'a, 'gcx, 'tcx> FnCtxt<'a, 'gcx, 'tcx> { | |||
| // This has nothing here because it means we did string | |||
| // concatenation (e.g. "Hello " + "World!"). This means | |||
| // we don't want the note in the else clause to be emitted | |||
| } else if let ty::TyParam(_) = lhs_ty.sty { | |||
| // FIXME: point to span of param | |||
There was a problem hiding this comment.
I have not been able to figure out how to get the span of T in the generic argument list in order to create a suggestion. The FnCtxt doesn't seem to store the generics or the DefId or the BodyId of the function it's currently checking.
There was a problem hiding this comment.
Nope. Presumably we could thread this information down.
There was a problem hiding this comment.
OK. I'll do that in a separate PR. This one already improves the message imo
There was a problem hiding this comment.
If we're going to solve this though, I'd really like to find a way to remove the Name from the ty::ParamIdx -- which presumably would require storing the set of in-scope generics into TLS somewhere (though that would possibly only be used by the Debug and Display impls).
kennytm
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 9e062c8 has been approved by |
Report a targeted note for generic parameters that are missing a trait bound
|
☀️ Test successful - status-appveyor, status-travis |
No description provided.