First cut at getting some part of the test suite working for CloudABI #47127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like many of these tests are already disabled on emscripten, which also doesn't seem to support environment variables and subprocess spawning. Just add a similar tag for CloudABI. While there, sort some of the lists of operating systems alphabetically.
CloudABI doesn't support the creation of dynamic libraries. Any test making use of auxiliary libraries will fail without this change applied.
CloudABI doesn't make any distinction between TTYs and ordinary pipes. While there, remove the redundant implementation used by Redox. It can use the same stub function.
Due to the disable-cloudabi tags being added to the source files, the expected output of the compiler is altered slightly.
EdSchouten
force-pushed
the
cloudabi-tests
branch
from
998d6c2 to
c51f878
Compare
kennytm
added
the
S-waiting-on-review
kennytm
requested changes
Jan 3, 2018
src/libtest/lib.rs
Outdated
| @@ -977,12 +977,9 @@ fn use_color(opts: &TestOpts) -> bool { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(target_os = "redox")] | |||
| fn stdout_isatty() -> bool { | |||
| // FIXME: Implement isatty on Redox | |||
kennytm
added
S-waiting-on-author
Requested by: kennytm
kennytm
approved these changes
Jan 3, 2018
|
@bors r+ |
|
📌 Commit 3ca407e has been approved by |
bors
added a commit
that referenced
this pull request
Jan 3, 2018
First cut at getting some part of the test suite working for CloudABI I am currently working on creating a Docker container for automated CI for CloudABI. Here are some of the trivial changes that need to land to make tests pass.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently working on creating a Docker container for automated CI for CloudABI. Here are some of the trivial changes that need to land to make tests pass.