Skip to content

Move the alloc::allocator module to core::heap #49481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2018
Merged

Move the alloc::allocator module to core::heap #49481

merged 1 commit into from
Mar 31, 2018

Conversation

SimonSapin
Copy link
Contributor

This is the Alloc trait and its dependencies.

@SimonSapin
Move the alloc::allocator module to core::heap
94d1970 
This is the `Alloc` trait and its dependencies.
@SimonSapin
Copy link
Contributor Author

r? @alexcrichton

@SimonSapin SimonSapin added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 29, 2018
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Mar 29, 2018

📌 Commit 94d1970 has been approved by alexcrichton

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 29, 2018
@glandium
Copy link
Contributor

Why core::heap and not core::allocator? core::heap won't even ever contain Heap

@alexcrichton
Copy link
Member

@glandium alloc::allocator wasn't intended to ever be a public/stable interface, and libcore is simply a subset of libstd so core::heap was a natural subset of std::heap

@bors
Copy link
Collaborator

bors commented Mar 31, 2018

⌛ Testing commit 94d1970 with merge 8dd24c8...

bors added a commit that referenced this pull request Mar 31, 2018
@bors
Auto merge of #49481 - SimonSapin:core-heap, r=alexcrichton
8dd24c8 
Move the alloc::allocator module to core::heap

This is the `Alloc` trait and its dependencies.
@SimonSapin
Copy link
Contributor Author

@glandium I’m also going to propose renaming the heap modules of respective crates to alloc, but maybe we should batch breaking changes together so that Nightly users can migrate at once. (I’m traveling right now, I’ll write up more soon.)

@bors
Copy link
Collaborator

bors commented Mar 31, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 8dd24c8 to master...

@bors bors merged commit 94d1970 into rust-lang:master Mar 31, 2018
@SimonSapin SimonSapin deleted the core-heap branch May 16, 2018 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SimonSapin @alexcrichton @bors @glandium @Kimundi