Cleaned up num <-> str conv functions #4957
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed hacky dependency on Round trait and generic infinity functions Removed generic-runtime-failure-depending-on-type behavior
Removed Round impl for integers
|
Looks good except for those predicates that seem to be unnecessary as required trait methods. If you remove those (or tell me the reason I've overlooked that they need to be in the trait) I'll approve it -- thanks! |
|
The idea was to be able to both query if a type supports one of the special values, and if yes, whether a value of the type is equal to one of them. But looking over it again, the |
Moved `is_*` predicates into standalone functions
|
Thanks! |
bors
added a commit
that referenced
this pull request
Feb 16, 2013
Moved them into own module and made them not depend on an Round trait impl for integers and generic math functions that can fail on integers any more.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2020
New Lint: Iter nth zero Check for the use of `iter.nth(0)` and encourage `iter.next()` instead as it is more readable changelog: add new lint when `iter.nth(0)` is used Fixes rust-lang#4957
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved them into own module and made them not depend on an Round trait impl for integers and generic math functions that can fail on integers any more.