Skip to content

Update rls -> faccf0d #49832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

alexheretic
Copy link
Member

Update rls -> rust-lang/rls@faccf0d using the latest clippy release

r? @nrc

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive
Copy link
Contributor

warning Warning warning

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 10, 2018
@TimNN
Copy link
Contributor

TimNN commented Apr 10, 2018

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:00:47] configure: rust.quiet-tests     := True
---
[00:01:23] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:23] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:23] Build completed unsuccessfully in 0:00:36
[00:01:23] make: *** [prepare] Error 1
[00:01:23] Makefile:81: recipe for target 'prepare' failed
[00:01:23] Command failed. Attempt 2/5:
[00:01:24]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:24] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:24] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:24] Build completed unsuccessfully in 0:00:00
[00:01:24] Makefile:81: recipe for target 'prepare' failed
[00:01:24] make: *** [prepare] Error 1
[00:01:24] Command failed. Attempt 3/5:
[00:01:24]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:24] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:24] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:24] Build completed unsuccessfully in 0:00:00
[00:01:24] Makefile:81: recipe for target 'prepare' failed
[00:01:24] make: *** [prepare] Error 1
[00:01:24] Command failed. Attempt 4/5:
[00:01:25]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:25] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:25] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:25] Build completed unsuccessfully in 0:00:00
[00:01:25] make: *** [prepare] Error 1
[00:01:25] Makefile:81: recipe for target 'prepare' failed
[00:01:25] Command failed. Attempt 5/5:
[00:01:25]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:25] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:25] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:25] Build completed unsuccessfully in 0:00:00
[00:01:25] make: *** [prepare] Error 1
[00:01:25] Makefile:81: recipe for target 'prepare' failed
[00:01:25] The command has failed after 5 attempts.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@nrc
Copy link
Member

nrc commented Apr 10, 2018

@bors: r+ p=10

@bors
Copy link
Collaborator

bors commented Apr 10, 2018

📌 Commit e1b0a75 has been approved by nrc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2018
@bors
Copy link
Collaborator

bors commented Apr 10, 2018

⌛ Testing commit e1b0a75 with merge 5bd0f17461da2d1ea713e1b7114c5c1679cede24...

@bors
Copy link
Collaborator

bors commented Apr 11, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 11, 2018
@alexheretic
Copy link
Member Author

Looks like one of the appveyor jobs timed out

@kennytm
Copy link
Member

kennytm commented Apr 11, 2018

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2018
@bors
Copy link
Collaborator

bors commented Apr 11, 2018

⌛ Testing commit e1b0a75 with merge 31da3d5b381f5c65739582c45f058a4c10f7fdea...

@bors
Copy link
Collaborator

bors commented Apr 11, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 11, 2018
@oli-obk
Copy link
Contributor

oli-obk commented Apr 11, 2018

Timed out again.

I opened a clippy + rls update in #49872

@alexheretic
Copy link
Member Author

Ok I'll leave this to #49872 then

@alexheretic alexheretic deleted the rls-faccf0d branch April 11, 2018 11:46
@oli-obk oli-obk mentioned this pull request Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants