use range asserts when loading bools and enum discriminants #5044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a way to test this change? I suppose it's mainly for performance? |
|
@catamorphism: it's pretty easy to sanity check by looking at the IR output and making sure the range is correct, I'm not sure if that could be made into a rustc test |
|
@thestinger Okay, don't worry about it right now. We don't have a great way to add that kind of test at the moment. |
bors
added a commit
that referenced
this pull request
Feb 20, 2013
Closes #4924 There are some more `Load` calls that could use this, so it's not completely done yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4924
There are some more
Loadcalls that could use this, so it's not completely done yet.