Fix for issue #4366, plug leaking of glob imports #5113
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry @alexcrichton , but do you mind rebasing? |
|
No problem, just rebased. |
|
Lovely, thanks! |
|
I'll rebase it for you this time, since you've already had to do it once :-) |
Also touch up use of 'pub' and move some tests around so the tested functions don't have to be 'pub'
|
Oh it's fine, I've been rebasing as things have been pushing to incoming, I just pushed a rebased version of the commits again. |
|
Thanks! |
bors
added a commit
that referenced
this pull request
Feb 28, 2013
The first two commits are the actual fix going into place, and the last is just dealing with the fallout in the rest of the compiler. The test added in the first two commits had 0 failures before this patch, and if the glob imports were changed to explicit imports then the errors showed up. Due to this behavior, I figured that the desired behavior was for glob imports to not accidentally leak a lot of non-public imports/functions/types into other modules. There was quite a lot of fallout, and it all passes `make check` locally, but I doubt that it will pass on all platforms because there's probably some guarded off thing I missed. I plan on making another patch soon which changes the default level of `unused_imports` to `warn` which will hopefully reduce a lot of the `use` noise throughout. In conjunction with #5104, and a few minor fixes, I think that the default level of `warn` is actually really usable.
|
I think that #4366 can also be closed now? |
|
Yes, and thanks for your effort! |
|
Thanks for the awesome language and being so open to contributions :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first two commits are the actual fix going into place, and the last is just dealing with the fallout in the rest of the compiler.
The test added in the first two commits had 0 failures before this patch, and if the glob imports were changed to explicit imports then the errors showed up. Due to this behavior, I figured that the desired behavior was for glob imports to not accidentally leak a lot of non-public imports/functions/types into other modules.
There was quite a lot of fallout, and it all passes
make checklocally, but I doubt that it will pass on all platforms because there's probably some guarded off thing I missed.I plan on making another patch soon which changes the default level of
unused_importstowarnwhich will hopefully reduce a lot of theusenoise throughout. In conjunction with #5104, and a few minor fixes, I think that the default level ofwarnis actually really usable.