Skip to content

test: Ignore some problematic tests on powerpc and powerpc64* #51392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2018

Conversation

glaubitz
Copy link
Contributor

@glaubitz glaubitz commented Jun 6, 2018

This updates the list of tests which can be safely ignored on powerpc and powerpc64*.

@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 6, 2018
@glaubitz
Copy link
Contributor Author

glaubitz commented Jun 6, 2018

Note: I was unable to run the testsuite locally, the testsuite wouldn't get past the tidycheck script. I am therefore waiting for the CI to fail now so I can update the line numbers in the stderr files.

CC @shepmaster

@rust-highfive
Copy link
Contributor

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@@ -13,6 +13,9 @@
// ignore-emscripten
// ignore-mips
// ignore-mips64
// ignore-powerpc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is for x86, so this makes sense.

@@ -13,6 +13,9 @@
// ignore-aarch64
// ignore-asmjs
// ignore-mips64
// ignore-powerpc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this. What platform is this not ignored for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea. The test was added like that in 2be697b.

Maybe @rkruppe can shed some light here?

@glaubitz
Copy link
Contributor Author

Could someone review this before the 1.27.0 release? @shepmaster ?

@glaubitz
Copy link
Contributor Author

@rust-highfive r?

@glaubitz
Copy link
Contributor Author

r?

@glaubitz
Copy link
Contributor Author

Can someone pick this up, please? Otherwise rustc 1.27 might not build on Debian/ppc64. Thanks.

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 17, 2018

📌 Commit d63aabc has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2018
@bors
Copy link
Collaborator

bors commented Jun 17, 2018

⌛ Testing commit d63aabc with merge 499583a...

bors added a commit that referenced this pull request Jun 17, 2018
test: Ignore some problematic tests on powerpc and powerpc64*

This updates the list of tests which can be safely ignored on powerpc and powerpc64*.
@bors
Copy link
Collaborator

bors commented Jun 17, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing 499583a to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants