Don't auto-hide inherent impls even if rustdoc-collapse == true.
#51527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
the
T-rustdoc
|
Some changes occurred in HTML/CSS. |
|
r? @frewsxcv (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
requested changes
Jun 13, 2018
src/librustdoc/html/static/main.js
Outdated
| onEach(document.getElementsByClassName("collapse-toggle"), function(e) { | ||
| collapseDocs(e, "show"); | ||
| }); | ||
| if (!fromAutoCollapse) { |
src/librustdoc/html/static/main.js
Outdated
| onEach(document.getElementsByClassName("collapse-toggle"), function(e) { | ||
| collapseDocs(e, "hide", pageId); | ||
| }); | ||
| if (!fromAutoCollapse) { |
|
Working fine for me so please fix my two comments and then it's good to go. Thanks! |
kennytm
force-pushed
the
do-not-auto-hide-inherent-impl
branch
from
8c54081 to
ca65a5e
Compare
|
@bors r=GuillaumeGomez |
|
📌 Commit ca65a5e has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 13, 2018
…laumeGomez Don't auto-hide inherent impls even if `rustdoc-collapse == true`. This PR changes the auto-collapse behavior when a page is first loaded: * Inherent impls will never be collapsed by default (new behavior). * Trait impls will always be collapsed by default, same as before. * Other items are collapsed according to localStorage, same as before. This should be much more useful since there is no hint what the content of a collapsed inherent impl would be (try to collapse everything in https://doc.rust-lang.org/std/vec/struct.Vec.html and guess where a method like `try_reserve` or `splice` would be). Manually clicking the global [-]/[+] will still collapse/expand everything.
|
@bors rollup |
GuillaumeGomez
approved these changes
Jun 13, 2018
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the auto-collapse behavior when a page is first loaded:
This should be much more useful since there is no hint what the content of a collapsed inherent impl would be (try to collapse everything in https://doc.rust-lang.org/std/vec/struct.Vec.html and guess where a method like
try_reserveorsplicewould be).Manually clicking the global [-]/[+] will still collapse/expand everything.