Fix erroneous error note when using field after move #51688

spastorino · 2018-06-21T18:09:42Z

nikomatsakis · 2018-06-21T18:17:07Z

src/librustc_mir/util/borrowck_errors.rs

                                 o: Origin)
                                 -> DiagnosticBuilder<'cx>
    {
+        let moved_path = moved_path.map(|mp| format!(": `{}`", mp)).unwrap_or("".to_owned());


do we have a test that shows the effect of this change? I don't see one... or is it that other tests regressed as a result?

the stderr files changed like in https://github.com/rust-lang/rust/pull/51688/files#diff-4d3cc9be8c38f963314cf51e57d3fcbcL23

nikomatsakis · 2018-06-21T18:22:04Z

@bors r+

bors · 2018-06-21T18:22:06Z

📌 Commit fe264bb6f0aa7efb7be3432360edd1f8923c1f80 has been approved by nikomatsakis

nikomatsakis · 2018-06-21T18:25:57Z

@bors r-

nikomatsakis · 2018-06-21T18:27:24Z

@bors r+ -- I was confused, seems fine

bors · 2018-06-21T18:27:24Z

📌 Commit fe264bb6f0aa7efb7be3432360edd1f8923c1f80 has been approved by nikomatsakis

bors · 2018-06-22T10:44:42Z

☔ The latest upstream changes (presumably #51660) made this pull request unmergeable. Please resolve the merge conflicts.

nikomatsakis · 2018-06-22T10:34:05Z

src/librustc_mir/borrow_check/error_reporting.rs

                Some(name) => format!("`{}`", name),
                None => "value".to_owned(),
            };
            self.tcx
                .cannot_act_on_uninitialized_variable(
                    span,
                    desired_action.as_noun(),
-                    &self.describe_place(place).unwrap_or("_".to_owned()),
+                    &self.describe_place(place, true).unwrap_or("_".to_owned()),


If we are going to have a flag -- which probably makes sense at this juncture -- I would prefer two distinct fns that wrap describe_place. I find "naked booleans" quite hard to read later on — maybe something like

describe_place_including_downcast(place)

describe_place_excluding_downcast(place)

descirbe_place(place, including_downcast: bool)

Or, better yet, since we aim to eventually never include downcasts, maybe we can make "excluding downcasts" be the default. Then we can make a newtype'd flag. Something like this:

struct IncludingPlace(bool); impl { fn describe_place(&self, place: &Place) { self.describe_place_with_options(place, IncludingDowncast(false)) } fn describe_place_with_options(&self, place: &Place, including_downcast: IncludingDowncast) { match place { .. Downcast(..) if including_downcast.0 => { ... } Downcast(..) => Err(()), } }

estebank · 2018-06-23T16:45:38Z

src/librustc_mir/borrow_check/error_reporting.rs

@@ -654,12 +668,26 @@ impl<'cx, 'gcx, 'tcx> MirBorrowckCtxt<'cx, 'gcx, 'tcx> {
    }
 }

+pub(super) struct IncludingDowncast(bool);


It's usually a bit more idiomatic to use an enum with the possible states, but this is still an improvement in readibility over a naked Boolean.

Yeah, I think I prefer an enum, was just following @nikomatsakis suggestion. But I'm fine with either.

estebank · 2018-06-23T16:52:14Z

src/test/ui/borrowck/issue-41962.stderr

  --> $DIR/issue-41962.rs:17:21
   |
 LL |         if let Some(thing) = maybe {
   |                     ^^^^^ value moved here in previous iteration of loop
   |
-   = note: move occurs because `maybe.0` has type `std::vec::Vec<bool>`, which does not implement the `Copy` trait
+   = note: move occurs because value has type `std::vec::Vec<bool>`, which does not implement the `Copy` trait


I wonder wether a small wording tweak would be warranted here:

Move occurs because the value has type

Move occurs because it has type

estebank · 2018-06-24T17:56:17Z

@bors r=nikomatsakis

bors · 2018-06-24T17:56:18Z

📌 Commit 1dae309 has been approved by nikomatsakis

rust-highfive · 2018-06-24T20:18:10Z

The job dist-i686-apple of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:02:57]       Memory: 8 GB
[00:02:57]       Boot ROM Version: VMW71.00V.0.B64.1704110547
[00:02:57]       Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
[00:02:57]       SMC Version (system): 2.8f0
[00:02:57]       Serial Number (system): VMnSXrFHKqSe
[00:02:57] 
[00:02:57] hw.ncpu: 4
[00:02:57] hw.byteorder: 1234
[00:02:57] hw.memsize: 8589934592
---
  0     0    0     0    0     0      0      0 --:--:--  0:01:17 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:01:18 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:01:19 --:--:--     0
[00:53:12] curl: (35) LibreSSL SSL_connect: SSL_ERROR_SYSCALL in connection to s3-us-west-1.amazonaws.com:443 
[00:53:12] thread 'main' panicked at 'failed to download openssl source: exit code: 35', bootstrap/native.rs:589:17
[00:53:12] failed to run: /Users/travis/build/rust-lang/rust/build/bootstrap/debug/bootstrap build
[00:53:12] Build completed unsuccessfully in 0:40:24
[00:53:12] Build completed unsuccessfully in 0:40:24
[00:53:12] make: *** [all] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1c2afd54
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_fold:start:after_failure.2
travis_time:start:01b1e939
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
total 0
drwx------+ 15 travis  staff  510 Jan 25 19:20 ..
drwx------   2 travis  staff   68 Dec  6  2017 .
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:072a99c8
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
travis_time:end:072a99c8:start=1529871472452324000,finish=1529871472474290000,duration=21966000
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:104ae678
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1d123df9
$ dmesg | grep -i kill
$ dmesg | grep -i kill
Unable to obtain kernel buffer: Operation not permitted
usage: sudo dmesg
travis_fold:end:after_failure.5

Done. Your build exited with 1.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-06-24T20:18:14Z

The job dist-i686-apple of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:02:57]       Memory: 8 GB
[00:02:57]       Boot ROM Version: VMW71.00V.0.B64.1704110547
[00:02:57]       Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
[00:02:57]       SMC Version (system): 2.8f0
[00:02:57]       Serial Number (system): VMnSXrFHKqSe
[00:02:57] 
[00:02:57] hw.ncpu: 4
[00:02:57] hw.byteorder: 1234
[00:02:57] hw.memsize: 8589934592
---
  0     0    0     0    0     0      0      0 --:--:--  0:01:17 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:01:18 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:01:19 --:--:--     0
[00:53:12] curl: (35) LibreSSL SSL_connect: SSL_ERROR_SYSCALL in connection to s3-us-west-1.amazonaws.com:443 
[00:53:12] thread 'main' panicked at 'failed to download openssl source: exit code: 35', bootstrap/native.rs:589:17
[00:53:12] failed to run: /Users/travis/build/rust-lang/rust/build/bootstrap/debug/bootstrap build
[00:53:12] Build completed unsuccessfully in 0:40:24
[00:53:12] Build completed unsuccessfully in 0:40:24
[00:53:12] make: *** [all] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1c2afd54
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_fold:start:after_failure.2
travis_time:start:01b1e939
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
total 0
drwx------+ 15 travis  staff  510 Jan 25 19:20 ..
drwx------   2 travis  staff   68 Dec  6  2017 .
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:072a99c8
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
travis_time:end:072a99c8:start=1529871472452324000,finish=1529871472474290000,duration=21966000
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:104ae678
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1d123df9
$ dmesg | grep -i kill
$ dmesg | grep -i kill
Unable to obtain kernel buffer: Operation not permitted
usage: sudo dmesg
travis_fold:end:after_failure.5

Done. Your build exited with 1.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

spastorino · 2018-06-24T20:20:29Z

@estebank @nikomatsakis failures are related to Travis issues ...

estebank · 2018-06-24T21:17:52Z

@bors retry

bors · 2018-06-24T22:02:16Z

⌛ Testing commit 1dae309 with merge 6ffc004cb6aae0aa1723dae93b756a669e43555e...

bors · 2018-06-24T22:06:07Z

💔 Test failed - status-travis

rust-highfive · 2018-06-24T22:06:08Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:00:48] sha256:5e8b97a2a0820b10338bd91674249a94679e4568fd1183ea46acff63b9883e9c
[00:00:48] Attempting with retry: docker build --rm -t rust-ci -f /home/travis/build/rust-lang/rust/src/ci/docker/dist-i586-gnu-i586-i686-musl/Dockerfile /home/travis/build/rust-lang/rust/src/ci/docker
[00:00:48] Sending build context to Docker daemon  501.2kB
[00:00:48] Step 1/13 : FROM ubuntu:16.04
[00:00:48] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: error parsing HTTP 404 response body: invalid character ':' after top-level value: "404: Page Not Found"
[00:00:49] Sending build context to Docker daemon  501.2kB
[00:00:49] Step 1/13 : FROM ubuntu:16.04
[00:00:49] Step 1/13 : FROM ubuntu:16.04
[00:00:49] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: error parsing HTTP 404 response body: invalid character ':' after top-level value: "404: Page Not Found"
[00:00:51] Sending build context to Docker daemon  501.2kB
[00:00:52] Step 1/13 : FROM ubuntu:16.04
[00:00:52] Step 1/13 : FROM ubuntu:16.04
[00:00:52] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: error parsing HTTP 404 response body: invalid character ':' after top-level value: "404: Page Not Found"
[00:00:55] Sending build context to Docker daemon  501.2kB
[00:00:55] Step 1/13 : FROM ubuntu:16.04
[00:00:55] Step 1/13 : FROM ubuntu:16.04
[00:00:55] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:00:59] Sending build context to Docker daemon  501.2kB
[00:00:59] Step 1/13 : FROM ubuntu:16.04
[00:00:59] Step 1/13 : FROM ubuntu:16.04
[00:01:00] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:01:00] The command has failed after 5 attempts.

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 1.
travis_time:start:186770a4
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:01829b63:start=1529877904406648426,finish=1529877904414793877,duration=8145451
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0084ded6
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1564c8e8
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-06-24T22:06:12Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:00:48] sha256:5e8b97a2a0820b10338bd91674249a94679e4568fd1183ea46acff63b9883e9c
[00:00:48] Attempting with retry: docker build --rm -t rust-ci -f /home/travis/build/rust-lang/rust/src/ci/docker/dist-i586-gnu-i586-i686-musl/Dockerfile /home/travis/build/rust-lang/rust/src/ci/docker
[00:00:48] Sending build context to Docker daemon  501.2kB
[00:00:48] Step 1/13 : FROM ubuntu:16.04
[00:00:48] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: error parsing HTTP 404 response body: invalid character ':' after top-level value: "404: Page Not Found"
[00:00:49] Sending build context to Docker daemon  501.2kB
[00:00:49] Step 1/13 : FROM ubuntu:16.04
[00:00:49] Step 1/13 : FROM ubuntu:16.04
[00:00:49] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: error parsing HTTP 404 response body: invalid character ':' after top-level value: "404: Page Not Found"
[00:00:51] Sending build context to Docker daemon  501.2kB
[00:00:52] Step 1/13 : FROM ubuntu:16.04
[00:00:52] Step 1/13 : FROM ubuntu:16.04
[00:00:52] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: error parsing HTTP 404 response body: invalid character ':' after top-level value: "404: Page Not Found"
[00:00:55] Sending build context to Docker daemon  501.2kB
[00:00:55] Step 1/13 : FROM ubuntu:16.04
[00:00:55] Step 1/13 : FROM ubuntu:16.04
[00:00:55] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:00:59] Sending build context to Docker daemon  501.2kB
[00:00:59] Step 1/13 : FROM ubuntu:16.04
[00:00:59] Step 1/13 : FROM ubuntu:16.04
[00:01:00] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:01:00] The command has failed after 5 attempts.

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 1.
travis_time:start:186770a4
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:01829b63:start=1529877904406648426,finish=1529877904414793877,duration=8145451
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0084ded6
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1564c8e8
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

estebank · 2018-06-24T22:18:45Z

@bors retry

bors · 2018-06-24T22:18:55Z

⌛ Testing commit 1dae309 with merge a9cbe64...

@nikomatsakis

…matsakis Fix erroneous error note when using field after move Closes #51512 r? @nikomatsakis

bors · 2018-06-24T22:22:06Z

💔 Test failed - status-travis

rust-highfive · 2018-06-24T22:22:07Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:00:53] sha256:8c1f0882640438d1d5e0c0acc857fedd1a16de0d9ee943660aa40de5c9b49bad
[00:00:53] Attempting with retry: docker build --rm -t rust-ci -f /home/travis/build/rust-lang/rust/src/ci/docker/x86_64-gnu-llvm-3.9/Dockerfile /home/travis/build/rust-lang/rust/src/ci/docker
[00:00:53] Sending build context to Docker daemon  501.2kB
[00:00:53] Step 1/6 : FROM ubuntu:16.04
[00:00:53] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:00:54] Sending build context to Docker daemon  501.2kB
[00:00:54] Step 1/6 : FROM ubuntu:16.04
[00:00:54] Step 1/6 : FROM ubuntu:16.04
[00:00:54] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:00:56] Sending build context to Docker daemon  501.2kB
[00:00:57] Step 1/6 : FROM ubuntu:16.04
[00:00:57] Step 1/6 : FROM ubuntu:16.04
[00:00:57] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:01:00] Sending build context to Docker daemon  501.2kB
[00:01:00] Step 1/6 : FROM ubuntu:16.04
[00:01:00] Step 1/6 : FROM ubuntu:16.04
[00:01:00] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:01:04] Sending build context to Docker daemon  501.2kB
[00:01:04] Step 1/6 : FROM ubuntu:16.04
[00:01:04] Step 1/6 : FROM ubuntu:16.04
[00:01:04] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:01:04] The command has failed after 5 attempts.

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 1.
travis_time:start:107bbf6c
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:03ff6e92:start=1529878892459700953,finish=1529878892470145131,duration=10444178
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:09763ec0
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:00f84904
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-06-24T22:22:11Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:00:53] sha256:8c1f0882640438d1d5e0c0acc857fedd1a16de0d9ee943660aa40de5c9b49bad
[00:00:53] Attempting with retry: docker build --rm -t rust-ci -f /home/travis/build/rust-lang/rust/src/ci/docker/x86_64-gnu-llvm-3.9/Dockerfile /home/travis/build/rust-lang/rust/src/ci/docker
[00:00:53] Sending build context to Docker daemon  501.2kB
[00:00:53] Step 1/6 : FROM ubuntu:16.04
[00:00:53] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:00:54] Sending build context to Docker daemon  501.2kB
[00:00:54] Step 1/6 : FROM ubuntu:16.04
[00:00:54] Step 1/6 : FROM ubuntu:16.04
[00:00:54] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:00:56] Sending build context to Docker daemon  501.2kB
[00:00:57] Step 1/6 : FROM ubuntu:16.04
[00:00:57] Step 1/6 : FROM ubuntu:16.04
[00:00:57] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:01:00] Sending build context to Docker daemon  501.2kB
[00:01:00] Step 1/6 : FROM ubuntu:16.04
[00:01:00] Step 1/6 : FROM ubuntu:16.04
[00:01:00] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:01:04] Sending build context to Docker daemon  501.2kB
[00:01:04] Step 1/6 : FROM ubuntu:16.04
[00:01:04] Step 1/6 : FROM ubuntu:16.04
[00:01:04] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:01:04] The command has failed after 5 attempts.

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 1.
travis_time:start:107bbf6c
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:03ff6e92:start=1529878892459700953,finish=1529878892470145131,duration=10444178
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:09763ec0
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:00f84904
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2018-06-25T04:54:50Z

@bors retry

bors · 2018-06-25T06:44:16Z

⌛ Testing commit 1dae309 with merge 5f9c7f9...

@nikomatsakis

…matsakis Fix erroneous error note when using field after move Closes #51512 r? @nikomatsakis

bors · 2018-06-25T08:54:11Z

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 5f9c7f9 to master...

rust-highfive assigned nikomatsakis Jun 21, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 21, 2018

nikomatsakis reviewed Jun 21, 2018

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 21, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 21, 2018

spastorino force-pushed the error-note-field-after-move branch from fe264bb to b9b0b93 Compare June 21, 2018 21:20

rust-lang deleted a comment from rust-highfive Jun 22, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 22, 2018

nikomatsakis requested changes Jun 22, 2018

View reviewed changes

spastorino force-pushed the error-note-field-after-move branch from 4203003 to 532e03a Compare June 22, 2018 16:29

spastorino added 2 commits June 22, 2018 18:23

Fix erroneous error note when using field after move

ad612d6

Run rustfmt

1dae309

spastorino force-pushed the error-note-field-after-move branch from 532e03a to 1dae309 Compare June 22, 2018 21:25

estebank reviewed Jun 23, 2018

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 24, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 24, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2018

bors added a commit that referenced this pull request Jun 24, 2018

Auto merge of #51688 - spastorino:error-note-field-after-move, r=niko…

a9cbe64

…matsakis Fix erroneous error note when using field after move Closes #51512 r? @nikomatsakis

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 24, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2018

bors added a commit that referenced this pull request Jun 25, 2018

Auto merge of #51688 - spastorino:error-note-field-after-move, r=niko…

5f9c7f9

…matsakis Fix erroneous error note when using field after move Closes #51512 r? @nikomatsakis

bors merged commit 1dae309 into rust-lang:master Jun 25, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix erroneous error note when using field after move #51688

Fix erroneous error note when using field after move #51688

spastorino commented Jun 21, 2018

nikomatsakis Jun 21, 2018

spastorino Jun 21, 2018

nikomatsakis commented Jun 21, 2018

bors commented Jun 21, 2018

nikomatsakis commented Jun 21, 2018

nikomatsakis commented Jun 21, 2018

bors commented Jun 21, 2018

bors commented Jun 22, 2018

nikomatsakis Jun 22, 2018

spastorino Jun 22, 2018

estebank Jun 23, 2018

spastorino Jun 24, 2018

estebank Jun 23, 2018

estebank commented Jun 24, 2018

bors commented Jun 24, 2018

rust-highfive commented Jun 24, 2018

rust-highfive commented Jun 24, 2018

spastorino commented Jun 24, 2018

estebank commented Jun 24, 2018

bors commented Jun 24, 2018

bors commented Jun 24, 2018

rust-highfive commented Jun 24, 2018

rust-highfive commented Jun 24, 2018

estebank commented Jun 24, 2018

bors commented Jun 24, 2018

bors commented Jun 24, 2018

rust-highfive commented Jun 24, 2018

rust-highfive commented Jun 24, 2018

kennytm commented Jun 25, 2018

bors commented Jun 25, 2018

bors commented Jun 25, 2018

Fix erroneous error note when using field after move #51688

Fix erroneous error note when using field after move #51688

Conversation

spastorino commented Jun 21, 2018

nikomatsakis Jun 21, 2018

Choose a reason for hiding this comment

spastorino Jun 21, 2018

Choose a reason for hiding this comment

nikomatsakis commented Jun 21, 2018

bors commented Jun 21, 2018

nikomatsakis commented Jun 21, 2018

nikomatsakis commented Jun 21, 2018

bors commented Jun 21, 2018

bors commented Jun 22, 2018

nikomatsakis Jun 22, 2018

Choose a reason for hiding this comment

spastorino Jun 22, 2018

Choose a reason for hiding this comment

estebank Jun 23, 2018

Choose a reason for hiding this comment

spastorino Jun 24, 2018

Choose a reason for hiding this comment

estebank Jun 23, 2018

Choose a reason for hiding this comment

estebank commented Jun 24, 2018

bors commented Jun 24, 2018

rust-highfive commented Jun 24, 2018

rust-highfive commented Jun 24, 2018

spastorino commented Jun 24, 2018

estebank commented Jun 24, 2018

bors commented Jun 24, 2018

bors commented Jun 24, 2018

rust-highfive commented Jun 24, 2018

rust-highfive commented Jun 24, 2018

estebank commented Jun 24, 2018

bors commented Jun 24, 2018

bors commented Jun 24, 2018

rust-highfive commented Jun 24, 2018

rust-highfive commented Jun 24, 2018

kennytm commented Jun 25, 2018

bors commented Jun 25, 2018

bors commented Jun 25, 2018