Skip to content

Fix: infer outlives requirements across crates #52010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2018

Conversation

toidiu
Copy link
Contributor

@toidiu toidiu commented Jul 3, 2018

Fixes #51858

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 3, 2018
@rust-highfive

This comment has been minimized.

@@ -82,7 +84,7 @@ fn inferred_outlives_of<'a, 'tcx>(

fn inferred_outlives_crate<'tcx>(
tcx: TyCtxt<'_, 'tcx, 'tcx>,
crate_num: CrateNum,
_cra: CrateNum,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be cleaning this up.

@toidiu toidiu force-pushed the ak-crossCrateOutlives branch from cbd2762 to 3f616cb Compare July 3, 2018 14:13
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 4, 2018

📌 Commit 3f616cb has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2018
@bors
Copy link
Collaborator

bors commented Jul 6, 2018

⌛ Testing commit 3f616cb with merge 062a416...

bors added a commit that referenced this pull request Jul 6, 2018
Fix: infer outlives requirements across crates

Fixes #51858
@bors
Copy link
Collaborator

bors commented Jul 6, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 062a416 to master...

@bors bors merged commit 3f616cb into rust-lang:master Jul 6, 2018
@toidiu toidiu deleted the ak-crossCrateOutlives branch July 6, 2018 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants