-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Improve output if no_lookup_host_duplicates test fails #54247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bors
merged 1 commit into
rust-lang:master
from
Munksgaard:better-error-message-in-no_lookup_host_duplicates
Sep 17, 2018
Merged
Improve output if no_lookup_host_duplicates test fails #54247
bors
merged 1 commit into
rust-lang:master
from
Munksgaard:better-error-message-in-no_lookup_host_duplicates
Sep 17, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @aidanhs (rust_highfive has picked a reviewer for you, use r? to override) |
r? @eddyb |
killercup
reviewed
Sep 15, 2018
src/libstd/sys_common/net.rs
Outdated
assert!(addrs.values().filter(|&&v| v > 1).count() == 0); | ||
for sa in lh { *addrs.entry(sa).or_insert(0) += 1; }; | ||
assert_eq!(addrs.iter().filter(|&(_, &v)| v > 1).collect::<Vec<_>>(), vec![], | ||
"There should be now duplicate localhost entries"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/now/no
If the test fails, output the offending addresses and a helpful error message. Also slightly improve legibility of the preceding line that puts the addresses into a HashMap.
2828396
to
0e9d260
Compare
@bors: r+ |
📌 Commit 0e9d260 has been approved by |
bors
added a commit
that referenced
this pull request
Sep 17, 2018
…ost_duplicates, r=alexcrichton Improve output if no_lookup_host_duplicates test fails If the test fails, output the offending addresses and a helpful error message. Also slightly improve legibility of the preceding line that puts the addresses into a HashMap.
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the test fails, output the offending addresses and a helpful error message.
Also slightly improve legibility of the preceding line that puts the addresses
into a HashMap.