Skip to content

Fix RLS toolstate after #54356 merge #54643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2018
Merged

Fix RLS toolstate after #54356 merge #54643

merged 1 commit into from
Sep 28, 2018

Conversation

Xanewok
Copy link
Member

@Xanewok Xanewok commented Sep 28, 2018

Fixes toolstate regression caused by #54356.

The save::process_crate now needs to be passed an additional &Input, this change contains the RLS equivalent of this.

r? @kennytm (or @nrc if you're not away yet)

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 28, 2018
@kennytm
Copy link
Member

kennytm commented Sep 28, 2018

@bors r+ p=2

@bors
Copy link
Collaborator

bors commented Sep 28, 2018

📌 Commit 632f3b1 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2018
@bors
Copy link
Collaborator

bors commented Sep 28, 2018

⌛ Testing commit 632f3b1 with merge 246dee4c33e7619f11860d44ad8d5212fd6e86af...

@bors
Copy link
Collaborator

bors commented Sep 28, 2018

💔 Test failed - status-travis

@rust-highfive
Copy link
Contributor

The job armhf-gnu of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_fold:end:system_info

Network availability confirmed.
Setting APT mirror in /etc/apt/sources.list: http://us-central1.gce.archive.ubuntu.com/ubuntu/
travis_fold:start:update_heroku
Updating Heroku
$ heroku version
heroku/7.16.0 linux-x64 node-v10.10.0
travis_fold:end:update_heroku
Installing APT Packages
travis_time:start:014b1f58
$ travis_apt_get_update
travis_time:end:014b1f58:start=1538157134823975382,finish=1538157139828327103,duration=5004351721
---
travis_time:end:271a0d12:start=1538158549999520696,finish=1538158550002889004,duration=3368308
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:00da5cf8
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:21427638
travis_time:start:21427638
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:1941b517
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 28, 2018
@Xanewok
Copy link
Member Author

Xanewok commented Sep 28, 2018

@kennytm seems spurious?

@alexcrichton
Copy link
Member

@bors: retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2018
@bors
Copy link
Collaborator

bors commented Sep 28, 2018

⌛ Testing commit 632f3b1 with merge 63d51e8...

bors added a commit that referenced this pull request Sep 28, 2018
Fix RLS toolstate after #54356 merge

Fixes toolstate regression caused by #54356.

The `save::process_crate` now needs to be passed an additional `&Input`, this change contains the RLS equivalent of [this](https://github.com/rust-lang/rust/pull/54356/files#diff-707a0eda6b2f1a0537abc3d23133748cR983).

r? @kennytm (or @nrc if you're not away yet)
@bors
Copy link
Collaborator

bors commented Sep 28, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing 63d51e8 to master...

@bors bors merged commit 632f3b1 into rust-lang:master Sep 28, 2018
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #54643!

Tested on commit 63d51e8.
Direct link to PR: #54643

🎉 rls on windows: build-fail → test-pass.
🎉 rls on linux: build-fail → test-pass.

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Sep 28, 2018
Tested on commit rust-lang/rust@63d51e8.
Direct link to PR: <rust-lang/rust#54643>

🎉 rls on windows: build-fail → test-pass.
🎉 rls on linux: build-fail → test-pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants