Skip to content

Use lld directly for Fuchsia target #55106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2018
Merged

Conversation

petrhosek
Copy link
Contributor

Fuchsia already uses lld as the default linker, so there's no reason
to always invoke it through Clang, instead we can simply invoke lld
directly and pass the set of flags that matches Clang.

@rust-highfive
Copy link
Contributor

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 16, 2018
@cramertj
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 16, 2018

📌 Commit 1ce8118462fcbc0c2bc69adaadee1f289f4cf449 has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2018
@cramertj cramertj requested a review from alexcrichton October 16, 2018 01:02
@kennytm
Copy link
Member

kennytm commented Oct 18, 2018

@bors r-

Failed in rollup #55171 (comment):

[00:45:56] warning: redundant linker flag specified for library `zircon`
[00:45:56] 
[00:46:04] error: linker `rust-lld` not found
[00:46:04]   = note: No such file or directory (os error 2)
[00:46:04] 
[00:46:04] error: aborting due to previous error

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 18, 2018
@cramertj
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 26, 2018

📌 Commit 544675f53abc58d4122c429cabb3e25a1d6a2b31 has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 26, 2018
@bors
Copy link
Collaborator

bors commented Oct 27, 2018

⌛ Testing commit 544675f53abc58d4122c429cabb3e25a1d6a2b31 with merge 3fc42611b7473e09e41f011c9da02293c9a7abc0...

@bors
Copy link
Collaborator

bors commented Oct 27, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 27, 2018
@rust-highfive
Copy link
Contributor

The job dist-various-2 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:02:25] Removing intermediate container b9872184686c
[00:02:25] Step 5/27 : RUN apt-key adv --batch --yes --keyserver keyserver.ubuntu.com --recv-keys 74DA7924C5513486
[00:02:25]  ---> Running in 4ed48fc81ddc
[00:02:25] Warning: apt-key output should not be parsed (stdout is not a terminal)
[00:02:26] Executing: /tmp/apt-key-gpghome.NbDMdPQ4fx/gpg.1.sh --batch --yes --keyserver keyserver.ubuntu.com --recv-keys 74DA7924C5513486
[00:02:28] gpg: Total number processed: 1
[00:02:28] gpg:               imported: 1
[00:02:28]  ---> f2a1d559c2c2
[00:02:28] Removing intermediate container 4ed48fc81ddc
---
travis_time:end:075ee977:start=1540614972451610527,finish=1540614972461279292,duration=9668765
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1d21293c
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:00594d36
travis_time:start:00594d36
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:19480533
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@kennytm
Copy link
Member

kennytm commented Oct 27, 2018

[00:31:18] configure: error: Option '--enable-lld' is not recognized

@cramertj
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 29, 2018

📌 Commit 8e2b70e269df1584675edc8246e51fcc28301221 has been approved by cramertj

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 29, 2018
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 29, 2018
@petrhosek
Copy link
Contributor Author

This is still failing for me locally when building the container but I'm looking into it.

@cramertj
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 29, 2018
Fuchsia already uses lld as the default linker, so there's no reason
to always invoke it through Clang, instead we can simply invoke lld
directly and pass the set of flags that matches Clang.
@petrhosek
Copy link
Contributor Author

This should be working now.

@alexcrichton
Copy link
Member

@bors: r+ delegate+

@bors
Copy link
Collaborator

bors commented Nov 5, 2018

✌️ @petrhosek can now approve this pull request

@bors
Copy link
Collaborator

bors commented Nov 5, 2018

📌 Commit 3d27aca has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 5, 2018
@bors
Copy link
Collaborator

bors commented Nov 6, 2018

⌛ Testing commit 3d27aca with merge 8aa9267...

bors added a commit that referenced this pull request Nov 6, 2018
Use lld directly for Fuchsia target

Fuchsia already uses lld as the default linker, so there's no reason
to always invoke it through Clang, instead we can simply invoke lld
directly and pass the set of flags that matches Clang.
@bors
Copy link
Collaborator

bors commented Nov 6, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 8aa9267 to master...

@bors bors merged commit 3d27aca into rust-lang:master Nov 6, 2018
@workingjubilee workingjubilee added the O-fuchsia Operating system: Fuchsia label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-fuchsia Operating system: Fuchsia S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants