-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Fixed: Multiple errors on single typo in match pattern #55156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
enum A { | ||
A { | ||
foo: usize, | ||
} | ||
} | ||
|
||
fn main() { | ||
let x = A::A { foo: 3 }; | ||
match x { | ||
A::A { fob } => { println!("{}", fob); } | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
error[E0026]: variant `A::A` does not have a field named `fob` | ||
--> $DIR/issue-52717.rs:19:12 | ||
| | ||
LL | A::A { fob } => { println!("{}", fob); } | ||
| ^^^ | ||
| | | ||
| variant `A::A` does not have this field | ||
| help: did you mean: `foo` | ||
|
||
error: aborting due to previous error | ||
|
||
For more information about this error, try `rustc --explain E0026`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,17 +2,11 @@ error[E0026]: variant `MyOption::MySome` does not have a field named `x` | |
--> $DIR/issue-17800.rs:18:28 | ||
| | ||
LL | MyOption::MySome { x: 42 } => (), | ||
| ^^^^^ variant `MyOption::MySome` does not have this field | ||
| ^^^^^ | ||
| | | ||
| variant `MyOption::MySome` does not have this field | ||
| help: did you mean: `0` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is unfortunate, but not a regression as we were already providing this suggestion/error. Ideally it should actually suggest |
||
|
||
error[E0027]: pattern does not mention field `0` | ||
--> $DIR/issue-17800.rs:18:9 | ||
| | ||
LL | MyOption::MySome { x: 42 } => (), | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ missing field `0` | ||
| | ||
= note: trying to match a tuple variant with a struct variant pattern | ||
|
||
error: aborting due to 2 previous errors | ||
error: aborting due to previous error | ||
|
||
Some errors occurred: E0026, E0027. | ||
For more information about an error, try `rustc --explain E0026`. | ||
For more information about this error, try `rustc --explain E0026`. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's another case that we're not handling (but it's fine):
In the present case after applying the suggestion, the code will complain about the printed
fob
, while in the quoted case we'll have two complains, one aboutfob
and another about the printedfoo
.It'll be interesting coming up with a solution for this as a follow up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working toward that :)