Skip to content

Add Unpin to std prelude, not just core #57137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2018
Merged

Conversation

cramertj
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 26, 2018
@kennytm kennytm added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. and removed relnotes Marks issues that should be documented in the release notes of the next release. labels Dec 27, 2018
@cramertj cramertj requested a review from SimonSapin December 27, 2018 19:31
@cramertj
Copy link
Member Author

(note to reviewers: this is just a bugfix to the API that was exposed previously)

@SimonSapin
Copy link
Contributor

I’ll assume that the since value of #[stable] attributes doesn’t matter on re-exports.

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 27, 2018

📌 Commit 11f4d3e has been approved by SimonSapin

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2018
@bors
Copy link
Collaborator

bors commented Dec 28, 2018

⌛ Testing commit 11f4d3e with merge b26e296d04f9d3db7b8e0488acc6a7799bf81c2c...

@bors
Copy link
Collaborator

bors commented Dec 28, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 28, 2018
@rust-highfive
Copy link
Contributor

The job dist-i586-gnu-i586-i686-musl of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:19:42] test atomic::uint_xor ... ok
[01:19:42] test cell::cell_default ... ok
[01:19:42] test cell::as_ptr ... ok
[01:19:42] test atomic::uint_or ... ok
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril
Copy link
Contributor

Centril commented Dec 28, 2018

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2018
@bors
Copy link
Collaborator

bors commented Dec 28, 2018

⌛ Testing commit 11f4d3e with merge 5e3fa89dfc7bf0ec41d252daeedadae8f8646702...

@bors
Copy link
Collaborator

bors commented Dec 28, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 28, 2018
@rust-highfive
Copy link
Contributor

The job dist-i686-freebsd of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
Building stage2 tool cargo (i686-unknown-freebsd)
[01:15:27]  Downloading crates ...
[01:15:47] warning: spurious network error (2 tries remaining): [6] Couldn't resolve host name (Could not resolve host: crates.io)
[01:16:08] warning: spurious network error (1 tries remaining): [6] Couldn't resolve host name (Could not resolve host: crates.io)
[01:16:28] error: failed to download from `https://crates.io/api/v1/crates/openssl-src/111.1.0+1.1.1a/download`
[01:16:28] Caused by:
[01:16:28]   [6] Couldn't resolve host name (Could not resolve host: crates.io)
[01:16:28] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "i686-unknown-freebsd" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/cargo/Cargo.toml" "--features" "rustc-workspace-hack/all-static" "--message-format" "json"
[01:16:28] expected success, got: exit code: 101
---
travis_time:end:003c5a36:start=1545979869302975644,finish=1545979869315334977,duration=12359333
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:025b2d24
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0a11c024
travis_time:start:0a11c024
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:07d360d4
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@kennytm
Copy link
Member

kennytm commented Dec 28, 2018

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2018
@bors
Copy link
Collaborator

bors commented Dec 28, 2018

⌛ Testing commit 11f4d3e with merge 48742c6...

bors added a commit that referenced this pull request Dec 28, 2018
Add Unpin to std prelude, not just core

r? @alexcrichton
@bors
Copy link
Collaborator

bors commented Dec 28, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: SimonSapin
Pushing 48742c6 to master...

@bors bors merged commit 11f4d3e into rust-lang:master Dec 28, 2018
@cramertj cramertj deleted the unpin-prelude branch December 28, 2018 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants