-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Tweak unicode escape diagnostics #57210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
r? @zackmdavis |
error: incorrect unicode escape sequence | ||
--> $DIR/format-string-error-2.rs:77:20 | ||
| | ||
LL | println!("/x7B}/u8 {", 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait ... the .rs file source line said println!("\x7B}\u8 {", 1);
(with backslashes), why are there forward slashes in the output here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zackmdavis can't find the PR, but UI tests normalize backslashes to forward slashes for Windows' sake to avoid further differences across platforms when running tests. It always makes me recoil for a second until I remember that that's a thing.
@bors r+ |
📌 Commit 30961c9 has been approved by |
⌛ Testing commit 30961c9 with merge 573d6fae1133ce2bf1a18e84c1088665a5e6c6b9... |
💔 Test failed - status-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Sounds fake. @bors retry |
☀️ Test successful - status-appveyor, status-travis |
No description provided.