Skip to content

Extend E0106, E0261 #57310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Extend E0106, E0261 #57310

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c738e60
Extend E0106, E0261
purple-ice Jan 3, 2019
adadefd
Fix changes for E0106, E0261
purple-ice Jan 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/librustc/diagnostics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,10 @@ struct Foo1 { x: &bool }
// ^ expected lifetime parameter
struct Foo2<'a> { x: &'a bool } // correct

impl Foo2 { ... }
// ^ expected lifetime parameter
impl<'a> Foo2<'a> { ... } // correct

struct Bar1 { x: Foo2 }
// ^^^^ expected lifetime parameter
struct Bar2<'a> { x: Foo2<'a> } // correct
Expand Down Expand Up @@ -772,6 +776,24 @@ struct Foo<'a> {
x: &'a str,
}
```

Implementations need their own lifetime declarations:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc suggestion:

Impl blocks declare lifetime parameters separately. You need to add lifetime parameters to an impl block if you're implementing a type that has a lifetime parameter of its own. For example:


```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these code blocks stand on their own, can you make sure to tag them with compile_fail,E0261 like the other failing sample in this excerpt? You'll also need to include the struct definition again.

// error, undeclared lifetime
impl Foo<'a> {
...
}
```

Which are declared like this:

```
// correct
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These code samples are tested, so please include the struct definition in this sample to make sure it properly compiles.

impl<'a> Foo<'a> {
...
}
```
"##,

E0262: r##"
Expand Down