Skip to content

Add FreeBSD armv6 and armv7 targets #58080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Mar 9, 2019
Merged

Add FreeBSD armv6 and armv7 targets #58080

merged 1 commit into from Mar 9, 2019
+54 −0

Conversation

ghost
Copy link

@ghost ghost commented Feb 2, 2019

No description provided.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 2, 2019
@ghost
Copy link
Author

ghost commented Feb 12, 2019

Anyone?

@Centril
Copy link
Contributor

Centril commented Feb 12, 2019

r? @nagisa

@rust-highfive rust-highfive assigned nagisa and unassigned eddyb Feb 12, 2019
@Centril Centril added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. labels Feb 12, 2019
@nagisa
Copy link
Member

nagisa commented Feb 12, 2019

@bors r+

LGTM, thanks!

@bors
Copy link
Collaborator

bors commented Feb 12, 2019

📌 Commit 6d85669 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2019
@Centril Centril mentioned this pull request Feb 13, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Feb 13, 2019

Failed in rollup (#58412 (comment)) due to 2018 changes, @bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 13, 2019
@ghost
Copy link
Author

ghost commented Feb 23, 2019

Is it ok now?

@sanxiyn
Copy link
Member

sanxiyn commented Mar 6, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 6, 2019

📌 Commit adddee4 has been approved by sanxiyn

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 6, 2019
@pietroalbini pietroalbini mentioned this pull request Mar 8, 2019
Merged
@bors bors merged commit adddee4 into rust-lang:master Mar 9, 2019
@ghost ghost deleted the freebsd_arm branch March 9, 2019 13:25
@Centril Centril added this to the 1.35 milestone Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nagisa nagisa

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.35
Development

Successfully merging this pull request may close these issues.
6 participants
@rust-highfive @Centril @nagisa @bors @sanxiyn @eddyb