Skip to content

Fix ICE on const evaluation of const method #60048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2019
Merged

Fix ICE on const evaluation of const method #60048

merged 1 commit into from
Apr 18, 2019

Conversation

estebank
Copy link
Contributor

Fix #54954.

@rust-highfive
Copy link
Contributor

r? @zackmdavis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 17, 2019
@sanxiyn
Copy link
Member

sanxiyn commented Apr 18, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 18, 2019

📌 Commit d56c820 has been approved by sanxiyn

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2019
@bors
Copy link
Collaborator

bors commented Apr 18, 2019

⌛ Testing commit d56c820 with merge be1dbaf...

bors added a commit that referenced this pull request Apr 18, 2019
@bors
Auto merge of #60048 - estebank:issue-54954, r=sanxiyn
be1dbaf 
Fix ICE on const evaluation of const method

Fix #54954.
@bors
Copy link
Collaborator

bors commented Apr 18, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: sanxiyn
Pushing be1dbaf to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 18, 2019
@bors bors merged commit d56c820 into rust-lang:master Apr 18, 2019
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #60048!

Tested on commit be1dbaf.
Direct link to PR: #60048

💔 rls on windows: test-pass → test-fail (cc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Apr 18, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#60048!
45ba254 
Tested on commit rust-lang/rust@be1dbaf.
Direct link to PR: <rust-lang/rust#60048>

💔 rls on windows: test-pass → test-fail (cc @Xanewok, @rust-lang/infra).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zackmdavis zackmdavis

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE when using const_fn in trait
5 participants
@estebank @rust-highfive @sanxiyn @bors @zackmdavis