Skip to content

checktools: unify grepping the TOOLSTATE file #61655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2019

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Jun 8, 2019

The file was grepped twice but in a different way. This unifies the code to make sure it is consistent. Or were these deliberately not doing the same thing? That seems strange though.

I wouldn't know how to test these changes.

@rust-highfive
Copy link
Contributor

r? @pietroalbini

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 8, 2019
@pietroalbini
Copy link
Member

r? @kennytm

@rust-highfive rust-highfive assigned kennytm and unassigned pietroalbini Jun 8, 2019
@kennytm
Copy link
Member

kennytm commented Jun 8, 2019

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 8, 2019

📌 Commit fea10c4 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2019
@bors
Copy link
Collaborator

bors commented Jun 8, 2019

⌛ Testing commit fea10c4 with merge 5c6f6b8...

bors added a commit that referenced this pull request Jun 8, 2019
checktools: unify grepping the TOOLSTATE file

The file was grepped twice but in a different way. This unifies the code to make sure it is consistent. Or were these deliberately not doing the same thing? That seems strange though.

I wouldn't know how to test these changes.
@bors
Copy link
Collaborator

bors commented Jun 8, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: kennytm
Pushing 5c6f6b8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 8, 2019
@bors bors merged commit fea10c4 into rust-lang:master Jun 8, 2019
@RalfJung RalfJung deleted the checktools branch June 9, 2019 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants