Skip to content

Update Clippy #64125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2019
Merged

Update Clippy #64125

merged 1 commit into from
Sep 4, 2019

Conversation

JohnTitor
Copy link
Member

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 3, 2019
@flip1995
Copy link
Member

flip1995 commented Sep 3, 2019

Would you mind bumping Clippy one more time? An ICE fix landed, just now: rust-lang/rust-clippy#4486

@JohnTitor
Copy link
Member Author

@flip1995 Sure! updated

@oli-obk
Copy link
Contributor

oli-obk commented Sep 3, 2019

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Sep 3, 2019

📌 Commit 3284734 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2019
@bors
Copy link
Collaborator

bors commented Sep 3, 2019

⌛ Testing commit 3284734 with merge 23cad87ab4ec357a091e7d44619dbf58bc523c58...

@bors
Copy link
Collaborator

bors commented Sep 4, 2019

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 4, 2019
@JohnTitor
Copy link
Member Author

@oli-obk could you run bors retry?

@phansch
Copy link
Member

phansch commented Sep 4, 2019

Maybe I can? (not sure if I understand the team/submodule permissions correctly)

@bors retry

@bors
Copy link
Collaborator

bors commented Sep 4, 2019

@phansch: 🔑 Insufficient privileges: not in try users

@flip1995
Copy link
Member

flip1995 commented Sep 4, 2019 •
edited
Loading

Every bors project has its own list for reviewers/tryers, independent of the status in the rust-lang org. Here's the one for rust: https://team-api.infra.rust-lang.org/v1/permissions/bors.rust.try.json

You can see those of other projects by changing the name at the end of the URL. (Not sure if there's an easier way to access this list though)

@bors
Copy link
Collaborator

bors commented Sep 4, 2019

⌛ Testing commit 3284734 with merge c6e9c76...

bors added a commit that referenced this pull request Sep 4, 2019
@bors
Auto merge of #64125 - JohnTitor:update-clippy, r=oli-obk
c6e9c76 
Update Clippy

cc rust-lang/rust-clippy#4493

r? @oli-obk
@bors
Copy link
Collaborator

bors commented Sep 4, 2019

☀️ Test successful - checks-azure
Approved by: oli-obk
Pushing c6e9c76 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 4, 2019
@bors bors merged commit 3284734 into rust-lang:master Sep 4, 2019
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #64125!

Tested on commit c6e9c76.
Direct link to PR: #64125

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch @flip1995, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch @flip1995, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Sep 4, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#64125!
e06621d 
Tested on commit rust-lang/rust@c6e9c76.
Direct link to PR: <rust-lang/rust#64125>

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch @flip1995, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch @flip1995, @rust-lang/infra).
@JohnTitor JohnTitor deleted the update-clippy branch September 4, 2019 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JohnTitor @rust-highfive @flip1995 @oli-obk @bors @phansch